sync: Make BaseNode lookup-related Init functions return specific failures.

chrome/browser/sync/glue/bookmark_model_associator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_GLUE_BOOKMARK_MODEL_ASSOCIATOR_H_
 #define CHROME_BROWSER_SYNC_GLUE_BOOKMARK_MODEL_ASSOCIATOR_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 60 matching lines @@
   // bookmark node id.
   virtual int64 GetSyncIdFromChromeId(const int64& node_id) OVERRIDE;
 
   // Returns the bookmark node for the given sync id.
   // Returns NULL if no bookmark node is found for the given sync id.
   virtual const BookmarkNode* GetChromeNodeFromSyncId(int64 sync_id) OVERRIDE;
 
   // Initializes the given sync node from the given bookmark node id.
   // Returns false if no sync node was found for the given bookmark node id or
   // if the initialization of sync node fails.
-  virtual bool InitSyncNodeFromChromeId(const int64& node_id,
-                                        sync_api::BaseNode* sync_node) OVERRIDE;
+  virtual bool InitSyncNodeFromChromeId(
+      const int64& node_id,
+      sync_api::BaseNode* sync_node) OVERRIDE;
 
   // Associates the given bookmark node with the given sync id.
   virtual void Associate(const BookmarkNode* node, int64 sync_id) OVERRIDE;
   // Remove the association that corresponds to the given sync id.
   virtual void Disassociate(int64 sync_id) OVERRIDE;
 
   virtual void AbortAssociation() OVERRIDE {
     // No implementation needed, this associator runs on the main
     // thread.
   }
@@ skipping 54 matching lines @@
   base::WeakPtrFactory<BookmarkModelAssociator> weak_factory_;
 
   int number_of_new_sync_nodes_created_at_association_;
 
   DISALLOW_COPY_AND_ASSIGN(BookmarkModelAssociator);
 };
 
 }  // namespace browser_sync
 
 #endif  // CHROME_BROWSER_SYNC_GLUE_BOOKMARK_MODEL_ASSOCIATOR_H_