Clean up leaks in gdata_db_unittest.cc

Clean up leaks in gdata_db_unittest.cc

BUG=124961
TEST=valgrind should be pleased.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134005

[achuithb, 2012-04-25 10:34:05]

Suppression here:
http://codereview.chromium.org/10222002/

[satorux1, 2012-04-25 17:47:23]

Please also remove the suppression.

http://codereview.chromium.org/10151013/diff/8001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_db_unittest.cc (right):

http://codereview.chromium.org/10151013/diff/8001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_db_unittest.cc:119:
STLDeleteElements(&entry_set_);
Is this the right place to delete? Shouldn't we do this in TearDown()?

[achuithb, 2012-04-25 18:34:38]

I've removed the suppressions as well.

http://codereview.chromium.org/10151013/diff/8001/chrome/browser/chromeos/gda...
File chrome/browser/chromeos/gdata/gdata_db_unittest.cc (right):

http://codereview.chromium.org/10151013/diff/8001/chrome/browser/chromeos/gda...
chrome/browser/chromeos/gdata/gdata_db_unittest.cc:119:
STLDeleteElements(&entry_set_);
On 2012/04/25 17:47:23, satorux1 wrote:
> Is this the right place to delete? Shouldn't we do this in TearDown()?

The root is already destroyed when we return from this function. There's no
point in holding on to the rest of the malloc'd memory any longer. These
temporary entries only need to exist when we're populating the database in this
function.

[satorux1, 2012-04-25 18:38:37]

LGTM

[achuithb, 2012-04-25 18:40:05]

On 2012/04/25 18:38:37, satorux1 wrote:
> LGTM

Thank you! Going to wait for the linux_chromeos valgrind bot, which hopefully
won't fail because of the #*&$ bluetooth issue.