Style cleanup in prerender_manager_factory.h/cc

Style cleanup in prerender_manager_factory.h/cc

Minor cleanups from my working copy.

BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133471

[gavinp, 2012-04-20 18:49:55]

wdyt?

[mmenke, 2012-04-20 18:59:58]

On 2012/04/20 18:49:55, gavinp wrote:
> wdyt?

The chromium style guide discourages inlining constructors/destructors.  Looks
like in this particular case, it should be fine, but I prefer to err on the side
of caution (And blindly following style guides).  Other changes look fine.

[mmenke, 2012-04-20 19:01:00]

https://chromiumcodereview.appspot.com/10146017/diff/1/chrome/browser/prerend...
File chrome/browser/prerender/prerender_manager_factory.cc (right):

https://chromiumcodereview.appspot.com/10146017/diff/1/chrome/browser/prerend...
chrome/browser/prerender/prerender_manager_factory.cc:59: }  // end namespace
prerender
nit:  While you're here, please remove the "end", too, come to think of it.

[gavinp, 2012-04-20 22:44:55]

On 2012/04/20 18:59:58, Matt Menke wrote:
> On 2012/04/20 18:49:55, gavinp wrote:
> > wdyt?
> 
> The chromium style guide discourages inlining constructors/destructors.  Looks
> like in this particular case, it should be fine, but I prefer to err on the
side
> of caution (And blindly following style guides).  Other changes look fine.

You're right.  Worse yet, I learned today we aren't using intelligent linking on
Windows, due to address space limitations.

Do you wish to despair?

~/chrome/src$ git grep '~[A-Za-z0-9_]*() *{ *}' -- '*.h' | wc
   1442    5766  111779
~/chrome/src$ git grep 'virtual.*~[A-Za-z0-9_]*() *{ *}' -- '*.h' | wc
   1319    5376  103376
~/chrome/src$ git grep '~[A-Za-z0-9_]*() *;' -- '*.h' | wc
   5511   15062  414131

My latest upload also includes the namespace comment fixes you requested.

[mmenke, 2012-04-20 23:06:31]

On 2012/04/20 22:44:55, gavinp wrote:
> On 2012/04/20 18:59:58, Matt Menke wrote:
> > On 2012/04/20 18:49:55, gavinp wrote:
> > > wdyt?
> > 
> > The chromium style guide discourages inlining constructors/destructors. 
Looks
> > like in this particular case, it should be fine, but I prefer to err on the
> side
> > of caution (And blindly following style guides).  Other changes look fine.
> 
> You're right.  Worse yet, I learned today we aren't using intelligent linking
on
> Windows, due to address space limitations.
> 
> Do you wish to despair?
> 
> ~/chrome/src$ git grep '~[A-Za-z0-9_]*() *{ *}' -- '*.h' | wc
>    1442    5766  111779
> ~/chrome/src$ git grep 'virtual.*~[A-Za-z0-9_]*() *{ *}' -- '*.h' | wc
>    1319    5376  103376
> ~/chrome/src$ git grep '~[A-Za-z0-9_]*() *;' -- '*.h' | wc
>    5511   15062  414131
> 
> My latest upload also includes the namespace comment fixes you requested.

What's worse is that I can't be sure any of those weren't mine, before it was in
the style guide (And/or before I knew it was there).

[mmenke, 2012-04-20 23:07:25]

Forgot the LGTM.

LGTM.

[gavinp, 2012-04-20 23:11:04]

On 2012/04/20 23:07:25, Matt Menke wrote:
> Forgot the LGTM.
> 
> LGTM.

Thank you.  Please ignore the crazy red trybots; I made a few bad patch uploads
before I figured out how to use git try.

[mmenke, 2012-04-20 23:18:05]

On 2012/04/20 23:11:04, gavinp wrote:
> On 2012/04/20 23:07:25, Matt Menke wrote:
> > Forgot the LGTM.
> > 
> > LGTM.
> 
> Thank you.  Please ignore the crazy red trybots; I made a few bad patch
uploads
> before I figured out how to use git try.

I just assumed LKGR was broken, since they didn't seem to be in files you
touched.  So used to spurious failures that I just don't trust the bots anymore.

[commit-bot: I haz the power, 2012-04-23 16:13:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gavinp@chromium.org/10146017/2003

[commit-bot: I haz the power, 2012-04-23 17:45:44]

Change committed as 133471