Fix wallpaper fade animation flashing problem.

Fix wallpaper fade animation flashing problem.


This CL fix the wallpaper fade animation problem. The problem was when user
switched to a new wallpaper, it seems there is a white flashing before new
wallpaper fade in.
The reason was I started the hide animation before loading new wallpaper. And it
took around 300ms to load while the animation finished around 200ms. So there is
100ms period where the background color (white) showed up.
I delayed the hide animation, but then another problem showed up. Now the show
and hide animation happened at the same time. At some point in the animation,
the background color will have 25% opacity and it also cause a flashing.

To fix all, this CL only animate on Show new wallpaper and delete the old widget
after the Show animation completed.

BUG=118651
TEST=Change wallpaper in chromeos, and verify if the animation is smooth.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133468

[bshe, 2012-04-20 18:57:12]

+ben, flackr 
Could you take a look please? Thanks! 

This CL fix the wallpaper fade animation problem. The problem was when user
switched to a new wallpaper, it seems there is a white flashing before new
wallpaper fade in.
The reason was I started the hide animation before loading new wallpaper. And it
took around 300ms to load while the animation finished around 200ms. So there is
100ms period where the background color (white) showed up.
I delayed the hide animation, but then another problem showed up. Now the show
and hide animation happened at the same time. At some point in the animation,
the background color will have 25% opacity and it also cause a flashing.

To fix all, this CL only animate on Show new wallpaper and delete the old widget
after the Show animation completed.

[flackr, 2012-04-20 19:04:51]

https://chromiumcodereview.appspot.com/10146016/diff/1/ash/desktop_background...
File ash/desktop_background/desktop_background_view.cc (right):

https://chromiumcodereview.appspot.com/10146016/diff/1/ash/desktop_background...
ash/desktop_background/desktop_background_view.cc:31: explicit
ShowWallpaperAnimationObserver(views::Widget* desktop_widget) :
nit: : goes on next line with desktop_widget_.

https://chromiumcodereview.appspot.com/10146016/diff/1/ash/desktop_background...
ash/desktop_background/desktop_background_view.cc:33: }
nit: newline between functions.

https://chromiumcodereview.appspot.com/10146016/diff/1/ash/desktop_background...
ash/desktop_background/desktop_background_view.cc:51: } // namespace
nit two spaces after }

https://chromiumcodereview.appspot.com/10146016/diff/1/ash/desktop_background...
ash/desktop_background/desktop_background_view.cc:144: ash::ANIMATE_SHOW);
nit: only indent 4 spaces.

[bshe, 2012-04-20 19:13:58]

Done. Thanks!

https://chromiumcodereview.appspot.com/10146016/diff/1/ash/desktop_background...
File ash/desktop_background/desktop_background_view.cc (right):

https://chromiumcodereview.appspot.com/10146016/diff/1/ash/desktop_background...
ash/desktop_background/desktop_background_view.cc:31: explicit
ShowWallpaperAnimationObserver(views::Widget* desktop_widget) :
On 2012/04/20 19:04:51, flackr wrote:
> nit: : goes on next line with desktop_widget_.

Done.

https://chromiumcodereview.appspot.com/10146016/diff/1/ash/desktop_background...
ash/desktop_background/desktop_background_view.cc:33: }
On 2012/04/20 19:04:51, flackr wrote:
> nit: newline between functions.

Done.

https://chromiumcodereview.appspot.com/10146016/diff/1/ash/desktop_background...
ash/desktop_background/desktop_background_view.cc:51: } // namespace
On 2012/04/20 19:04:51, flackr wrote:
> nit two spaces after }

Done.

[flackr, 2012-04-20 19:17:11]

lgtm with nit.

https://chromiumcodereview.appspot.com/10146016/diff/4001/ash/desktop_backgro...
File ash/desktop_background/desktop_background_view.cc (right):

https://chromiumcodereview.appspot.com/10146016/diff/4001/ash/desktop_backgro...
ash/desktop_background/desktop_background_view.cc:145: ash::ANIMATE_SHOW);
On 2012/04/20 19:04:51, flackr wrote:
> nit: only indent 4 spaces.

Missed this one.

[Ben Goodger (Google), 2012-04-23 15:38:22]

lgtm

[commit-bot: I haz the power, 2012-04-23 15:51:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bshe@chromium.org/10146016/6002

[commit-bot: I haz the power, 2012-04-23 17:29:36]

Change committed as 133468