Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 10146012: Add a wrong key test into EncryptorTest. (Closed)

Created:
8 years, 8 months ago by xhwang
Modified:
8 years, 8 months ago
Reviewers:
wtc
CC:
chromium-reviews
Visibility:
Public.

Description

Add a wrong key test into EncryptorTest. The behavior of crypto::Encryptor::Decrypt() funcion is different on different platforms. Add this test to test this. BUG=124434 TEST=this is a new test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133569

Patch Set 1 #

Patch Set 2 : Fix test and add comments #

Patch Set 3 : #

Patch Set 4 : Use a seperate decryptor for decryption to avoid assert on Windows. #

Patch Set 5 : Fix typo encryptor->decryptor #

Total comments: 2

Patch Set 6 : Remove redundant check as commented. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M crypto/encryptor_unittest.cc View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xhwang
Hello wtc, Revised the test based on your comments. Please review. xhwang
8 years, 8 months ago (2012-04-23 02:56:00 UTC) #1
wtc
Patch set 5 LGTM. http://codereview.chromium.org/10146012/diff/5005/crypto/encryptor_unittest.cc File crypto/encryptor_unittest.cc (right): http://codereview.chromium.org/10146012/diff/5005/crypto/encryptor_unittest.cc#newcode59 crypto/encryptor_unittest.cc:59: EXPECT_LT(0U, ciphertext.size()); I suggest removing ...
8 years, 8 months ago (2012-04-23 21:46:41 UTC) #2
xhwang
http://codereview.chromium.org/10146012/diff/5005/crypto/encryptor_unittest.cc File crypto/encryptor_unittest.cc (right): http://codereview.chromium.org/10146012/diff/5005/crypto/encryptor_unittest.cc#newcode59 crypto/encryptor_unittest.cc:59: EXPECT_LT(0U, ciphertext.size()); On 2012/04/23 21:46:41, wtc wrote: > > ...
8 years, 8 months ago (2012-04-23 21:54:05 UTC) #3
wtc
Patch set 6 LGTM.
8 years, 8 months ago (2012-04-23 22:02:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/10146012/14001
8 years, 8 months ago (2012-04-23 22:20:18 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 23:51:45 UTC) #6
Change committed as 133569

Powered by Google App Engine
This is Rietveld 408576698