Issue 10143008: Do not run netflix test in 'FULL' pyauto suite

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10143008: Do not run netflix test in 'FULL' pyauto suite (Closed)

Created:
8 years, 8 months ago by Nirnimesh

Modified:
8 years, 8 months ago

Reviewers:
dennis_jeffrey, rohitbm

CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do not run netflix test in 'FULL' pyauto suite - netflix tests will be run in another (pyauto_basic) suite on chromeos - Separate out the guest mode test, deal with login/logouts uniformly BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133311

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3

Patch Set 3 : . #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -26 lines)			Patch
	M	chrome/test/functional/PYAUTO_TESTS	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	chrome/test/functional/netflix.py	View	1 2	6 chunks	+45 lines, -25 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dennis_jeffrey

8 years, 8 months ago (2012-04-20 23:20:06 UTC) #2

LGTM with 3 style nits.

http://codereview.chromium.org/10143008/diff/2001/chrome/test/functional/netf...
File chrome/test/functional/netflix.py (right):

http://codereview.chromium.org/10143008/diff/2001/chrome/test/functional/netf...
chrome/test/functional/netflix.py:199: 
add 1 more blank line to separate top-level classes

http://codereview.chromium.org/10143008/diff/2001/chrome/test/functional/netf...
chrome/test/functional/netflix.py:223: """Test that Netflix doesn't play in
Guest mode login"""
nit: 'Guest' --> 'guest' to keep capitalization consistent with line 201 above

http://codereview.chromium.org/10143008/diff/2001/chrome/test/functional/netf...
chrome/test/functional/netflix.py:223: """Test that Netflix doesn't play in
Guest mode login"""
also add period at end of sentence

Expand Messages | Collapse Messages