[Print Preview] Refactored code to support auto fit to page functionality.

[Print Preview] Refactored code to support auto fit to page functionality.

(1) Added |fit_to_paper_size| member variable in PrintMsg_Print_Params.
(2) Removed |fit_to_page_| from PrintWebViewHelper.
(3) Modified PrintWebViewHelper member functions accordingly.

BUG=85132
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133131

[vandebo (ex-Chrome), 2012-04-19 23:56:07]

http://codereview.chromium.org/10142002/diff/1/chrome/renderer/print_web_view...
File chrome/renderer/print_web_view_helper.cc (right):

http://codereview.chromium.org/10142002/diff/1/chrome/renderer/print_web_view...
chrome/renderer/print_web_view_helper.cc:1253: settings.params.fit_to_paper_size
= !(PrintingNodeOrPdfFrame(frame, node) &&
Looks like there's only one caller to this method.  Maybe compute the bool at
the call site and pass it here.

http://codereview.chromium.org/10142002/diff/1/chrome/renderer/print_web_view...
chrome/renderer/print_web_view_helper.cc:1254:
frame->isPrintScalingDisabledForPlugin(node));
Is this a change in behavior?  For a refactoring change, try to minimize the
number of changes/fixes - make those different CLs.

http://codereview.chromium.org/10142002/diff/1/chrome/renderer/print_web_view...
chrome/renderer/print_web_view_helper.cc:1382: bool fit_to_paper_size = true;
Looks like you're making changes here as well.

http://codereview.chromium.org/10142002/diff/1/chrome/renderer/print_web_view...
chrome/renderer/print_web_view_helper.cc:1388: settings.params.fit_to_paper_size
= fit_to_paper_size;
Looks like you can negate the conditional in the if and assign that directly to
settings.params.fit_to_paper_size.

[kmadhusu, 2012-04-20 00:36:37]

http://codereview.chromium.org/10142002/diff/1/chrome/renderer/print_web_view...
File chrome/renderer/print_web_view_helper.cc (right):

http://codereview.chromium.org/10142002/diff/1/chrome/renderer/print_web_view...
chrome/renderer/print_web_view_helper.cc:1253: settings.params.fit_to_paper_size
= !(PrintingNodeOrPdfFrame(frame, node) &&
On 2012/04/19 23:56:07, vandebo wrote:
> Looks like there's only one caller to this method.  Maybe compute the bool at
> the call site and pass it here.

ok.

http://codereview.chromium.org/10142002/diff/1/chrome/renderer/print_web_view...
chrome/renderer/print_web_view_helper.cc:1254:
frame->isPrintScalingDisabledForPlugin(node));
On 2012/04/19 23:56:07, vandebo wrote:
> Is this a change in behavior?  For a refactoring change, try to minimize the
> number of changes/fixes - make those different CLs.

Reverted the changes.

http://codereview.chromium.org/10142002/diff/1/chrome/renderer/print_web_view...
chrome/renderer/print_web_view_helper.cc:1382: bool fit_to_paper_size = true;
On 2012/04/19 23:56:07, vandebo wrote:
> Looks like you're making changes here as well.

Reverted these changes.

http://codereview.chromium.org/10142002/diff/1/chrome/renderer/print_web_view...
chrome/renderer/print_web_view_helper.cc:1388: settings.params.fit_to_paper_size
= fit_to_paper_size;
On 2012/04/19 23:56:07, vandebo wrote:
> Looks like you can negate the conditional in the if and assign that directly
to
> settings.params.fit_to_paper_size.

Will do this in the next CL.

[vandebo (ex-Chrome), 2012-04-20 00:46:48]

LGTM

[commit-bot: I haz the power, 2012-04-20 00:49:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/10142002/7011

[commit-bot: I haz the power, 2012-04-20 02:45:48]

Change committed as 133131