Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 10141008: Make managedMode extension API component-only. (Closed)

Created:
8 years, 8 months ago by Bernhard Bauer
Modified:
8 years, 8 months ago
Reviewers:
Finnur
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org, Pam (message me for reviews)
Visibility:
Public.

Description

Make managedMode extension API component-only. To use the API in an extension now, load it as a component extension via --load-component-extension. BUG=115448 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133926

Patch Set 1 #

Patch Set 2 : api test #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -738 lines) Patch
M chrome/browser/extensions/extension_managed_mode_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_managed_mode_apitest.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/extension_preference_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +3 lines, -2 lines 0 comments Download
D chrome/common/extensions/api/experimental.managedMode.json View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/extensions/api/managedModePrivate.json View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/experimental.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/experimental.managedMode.html View 1 chunk +0 lines, -572 lines 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/common/extensions/docs/static/experimental.managedMode.html View 1 chunk +0 lines, -81 lines 0 comments Download
M chrome/common/extensions/extension_permission_set.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_permission_set.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_permission_set_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions_api_resources.grd View 2 chunks +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/managedMode/manifest.json View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/managedMode/test.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Bernhard Bauer
Please review. Thanks!
8 years, 8 months ago (2012-04-25 11:39:33 UTC) #1
Finnur
The change LGTM but is there a discussion/decision anywhere that confirms we think now is ...
8 years, 8 months ago (2012-04-25 14:25:20 UTC) #2
Bernhard Bauer
On 2012/04/25 14:25:20, Finnur wrote: > The change LGTM but is there a discussion/decision anywhere ...
8 years, 8 months ago (2012-04-25 14:33:04 UTC) #3
Finnur
No, it's just that I'm always hesitant about making a call to graduate something as ...
8 years, 8 months ago (2012-04-25 14:42:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10141008/9001
8 years, 8 months ago (2012-04-25 15:12:46 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 16:41:25 UTC) #6
Change committed as 133926

Powered by Google App Engine
This is Rietveld 408576698