Issue 10140016: Reimplement MonitorCellularDataPlan without Libcros

Issue 10140016: Reimplement MonitorCellularDataPlan without Libcros (Closed)

Created:
8 years, 8 months ago by hashimoto

Modified:
8 years, 8 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reimplement MonitorCellularDataPlan without Libcros BUG=chromium-os:16557 TEST=unit_tests --gtest_filter="CrosNetworkFunctions*" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133919

Patch Set 4 : Rebase #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -1 line)			Patch
	M	chrome/browser/chromeos/cros/cros_network_functions.cc	View	1 2	2 chunks	+105 lines, -1 line	0 comments	Download
	M	chrome/browser/chromeos/cros/cros_network_functions_unittest.cc	View	1	1 chunk	+62 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hashimoto

This change depends on http://codereview.chromium.org/10207006/ ("Move CellularDataPlanInfo to CellularDataPlan conversion code to cros_network_functions.cc")

8 years, 8 months ago (2012-04-24 06:34:57 UTC) #1

stevenjb

lgtm http://codereview.chromium.org/10140016/diff/4001/chrome/browser/chromeos/cros/cros_network_functions.cc File chrome/browser/chromeos/cros/cros_network_functions.cc (right): http://codereview.chromium.org/10140016/diff/4001/chrome/browser/chromeos/cros/cros_network_functions.cc#newcode190 chrome/browser/chromeos/cros/cros_network_functions.cc:190: LOG_IF(ERROR, !result) << "Cannnot get property " << ...

8 years, 8 months ago (2012-04-25 01:37:49 UTC) #2

hashimoto

8 years, 8 months ago (2012-04-25 15:40:17 UTC) #3

http://codereview.chromium.org/10140016/diff/4001/chrome/browser/chromeos/cro...
File chrome/browser/chromeos/cros/cros_network_functions.cc (right):

http://codereview.chromium.org/10140016/diff/4001/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/cros_network_functions.cc:190: LOG_IF(ERROR,
!result) << "Cannnot get property " << key;
On 2012/04/25 01:37:50, stevenjb (chromium) wrote:
> should just be a WARNING

Done.

http://codereview.chromium.org/10140016/diff/4001/chrome/browser/chromeos/cro...
chrome/browser/chromeos/cros/cros_network_functions.cc:205: LOG(ERROR) <<
"Cannnot get property " << key;
On 2012/04/25 01:37:50, stevenjb (chromium) wrote:
> WARNING

Done.

Expand Messages | Collapse Messages