Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: tools/isolate/isolate_smoke_test.py

Issue 10139020: Change --variable argument, must now be spaced, -V foo bar, instead of -V foo=bar. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/isolate/isolate.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/isolate/isolate_smoke_test.py
diff --git a/tools/isolate/isolate_smoke_test.py b/tools/isolate/isolate_smoke_test.py
index 178ef61bd6e1179950443302f06537a3c46139f6..33d7f7b4f1b1c8112d2edb60666f7d659a28b09e 100755
--- a/tools/isolate/isolate_smoke_test.py
+++ b/tools/isolate/isolate_smoke_test.py
@@ -270,7 +270,7 @@ class Isolate_check(IsolateBase):
self._expected_result(['touch_root.py'], None)
def test_with_flag(self):
- self._execute('check', 'with_flag.isolate', ['-V', 'FLAG=gyp'], False)
+ self._execute('check', 'with_flag.isolate', ['-V', 'FLAG', 'gyp'], False)
self._expect_no_tree()
self._expected_result(['with_flag.py', 'gyp'], None)
@@ -317,7 +317,8 @@ class Isolate_hashtable(IsolateBase):
self._expected_result(['touch_root.py'], None)
def test_with_flag(self):
- self._execute('hashtable', 'with_flag.isolate', ['-V', 'FLAG=gyp'], False)
+ self._execute(
+ 'hashtable', 'with_flag.isolate', ['-V', 'FLAG', 'gyp'], False)
self._expected_hash_tree()
self._expected_result(['with_flag.py', 'gyp'], None)
@@ -359,7 +360,7 @@ class Isolate_remap(IsolateBase):
self._expected_result(['touch_root.py'], None)
def test_with_flag(self):
- self._execute('remap', 'with_flag.isolate', ['-V', 'FLAG=gyp'], False)
+ self._execute('remap', 'with_flag.isolate', ['-V', 'FLAG', 'gyp'], False)
self._expected_tree()
self._expected_result(['with_flag.py', 'gyp'], None)
@@ -412,7 +413,7 @@ class Isolate_run(IsolateBase):
self._expected_result(['touch_root.py'], None)
def test_with_flag(self):
- self._execute('run', 'with_flag.isolate', ['-V', 'FLAG=run'], False)
+ self._execute('run', 'with_flag.isolate', ['-V', 'FLAG', 'run'], False)
# Not sure about the empty tree, should be deleted.
self._expect_empty_tree()
self._expected_result(['with_flag.py', 'run'], None)
@@ -493,7 +494,7 @@ class Isolate_trace(IsolateBase):
def test_with_flag(self):
out = self._execute(
- 'trace', 'with_flag.isolate', ['-V', 'FLAG=trace'], True)
+ 'trace', 'with_flag.isolate', ['-V', 'FLAG', 'trace'], True)
self._expect_no_tree()
self._expected_result(['with_flag.py', 'trace'], None)
expected = {
« no previous file with comments | « tools/isolate/isolate.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698