Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 10139020: Change --variable argument, must now be spaced, -V foo bar, instead of -V foo=bar. (Closed)

Created:
8 years, 8 months ago by M-A Ruel
Modified:
8 years, 8 months ago
CC:
chromium-reviews, pam+watch_chromium.org, erikwright (departed), cbentzel+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, csharp
Visibility:
Public.

Description

Change --variable argument, must now be spaced, -V foo bar, instead of -V foo=bar. Otherwise, path quoting gets in the way on windows in a way that is very hard to fix, as the 'bar' value could have double-quote in it, resulting in something like foo="bar". R=nsylvain@chromium.org R=mark@chromium.org R=rsleevi@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133398

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M base/base.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M net/net.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/cacheinvalidation/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/cacheinvalidation/cacheinvalidation.gyp View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/isolate/isolate.py View 3 chunks +6 lines, -5 lines 0 comments Download
M tools/isolate/isolate_smoke_test.py View 5 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
M-A Ruel
8 years, 8 months ago (2012-04-21 02:46:20 UTC) #1
Mark Mentovai
LGTM
8 years, 8 months ago (2012-04-21 15:45:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10139020/1
8 years, 8 months ago (2012-04-21 15:49:37 UTC) #3
commit-bot: I haz the power
Presubmit check for 10139020-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-21 15:49:52 UTC) #4
Ryan Sleevi
lgtm
8 years, 8 months ago (2012-04-21 16:10:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10139020/1
8 years, 8 months ago (2012-04-21 16:10:57 UTC) #6
commit-bot: I haz the power
Try job failure for 10139020-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-21 18:53:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10139020/1
8 years, 8 months ago (2012-04-23 01:51:13 UTC) #8
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 03:05:38 UTC) #9
Change committed as 133398

Powered by Google App Engine
This is Rietveld 408576698