[webui settings] send user profiles info earlier during load

[webui settings] send user profiles info earlier during load

this prevents jiggle during load because the profile info is available from when the page first loads, instead of a split second later.

BUG=none
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133562

[Miranda Callahan, 2012-04-23 12:41:04]

Shunting to Sailesh, who created the profile menu feature.

[sail, 2012-04-23 15:44:53]

LGTM!

http://codereview.chromium.org/10139019/diff/1/chrome/browser/ui/webui/option...
File chrome/browser/ui/webui/options2/browser_options_handler2.cc (right):

http://codereview.chromium.org/10139019/diff/1/chrome/browser/ui/webui/option...
chrome/browser/ui/webui/options2/browser_options_handler2.cc:907: ListValue*
profile_info_list = new ListValue;
Maybe make this a scoped_ptr and do a release at the bottom? Even better, could
this function just return a scoped_ptr? That way you can get rid of the comment
about caller taking ownership.

[sail, 2012-04-23 15:45:19]

oops, hit return too quickly.
Adding binji to the CC list since he wrote this code.

[binji, 2012-04-23 16:25:01]

On 2012/04/23 15:45:19, sail wrote:
> oops, hit return too quickly.
> Adding binji to the CC list since he wrote this code.

lgtm

[Evan Stade, 2012-04-23 20:19:02]

http://codereview.chromium.org/10139019/diff/1/chrome/browser/ui/webui/option...
File chrome/browser/ui/webui/options2/browser_options_handler2.cc (right):

http://codereview.chromium.org/10139019/diff/1/chrome/browser/ui/webui/option...
chrome/browser/ui/webui/options2/browser_options_handler2.cc:907: ListValue*
profile_info_list = new ListValue;
On 2012/04/23 15:44:53, sail wrote:
> Maybe make this a scoped_ptr and do a release at the bottom? Even better,
could
> this function just return a scoped_ptr? That way you can get rid of the
comment
> about caller taking ownership.

that would delete the object

[commit-bot: I haz the power, 2012-04-23 20:20:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/10139019/1

[Evan Stade, 2012-04-23 21:23:00]

On 2012/04/23 20:19:02, Evan Stade wrote:
>
http://codereview.chromium.org/10139019/diff/1/chrome/browser/ui/webui/option...
> File chrome/browser/ui/webui/options2/browser_options_handler2.cc (right):
> 
>
http://codereview.chromium.org/10139019/diff/1/chrome/browser/ui/webui/option...
> chrome/browser/ui/webui/options2/browser_options_handler2.cc:907: ListValue*
> profile_info_list = new ListValue;
> On 2012/04/23 15:44:53, sail wrote:
> > Maybe make this a scoped_ptr and do a release at the bottom? Even better,
> could
> > this function just return a scoped_ptr? That way you can get rid of the
> comment
> > about caller taking ownership.
> 
> that would delete the object

wait, I'm wrong.

[Evan Stade, 2012-04-23 21:55:47]

https://chromiumcodereview.appspot.com/10139019/diff/1/chrome/browser/ui/webu...
File chrome/browser/ui/webui/options2/browser_options_handler2.cc (right):

https://chromiumcodereview.appspot.com/10139019/diff/1/chrome/browser/ui/webu...
chrome/browser/ui/webui/options2/browser_options_handler2.cc:907: ListValue*
profile_info_list = new ListValue;
On 2012/04/23 15:44:53, sail wrote:
> Maybe make this a scoped_ptr and do a release at the bottom? Even better,
could
> this function just return a scoped_ptr? That way you can get rid of the
comment
> about caller taking ownership.

Done.

[commit-bot: I haz the power, 2012-04-23 21:56:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/10139019/20001

[commit-bot: I haz the power, 2012-04-23 23:20:09]

Change committed as 133562