Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: chrome/browser/platform_util_chromeos.cc

Issue 10139002: Preventing our default handlers for ChromeOS to show up or confuse the user (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Resolving merge issues Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/platform_util_chromeos.cc
diff --git a/chrome/browser/platform_util_chromeos.cc b/chrome/browser/platform_util_chromeos.cc
index eaebafd1c823924b69dcd06f5403c3c1aa22422a..12d0c789d0ec569264e1b920a3802d4d1266dc97 100644
--- a/chrome/browser/platform_util_chromeos.cc
+++ b/chrome/browser/platform_util_chromeos.cc
@@ -55,6 +55,15 @@ void OpenItem(const FilePath& full_path) {
}
void OpenExternal(const GURL& url) {
+ // This code should be obsolete since we have default handlers in ChromeOS
+ // which should handle this. However - there are two things which make it
+ // necessary to keep it in:
+ // a.) The user might have deleted the default handler in this session.
+ // In this case we would need to have this in place.
+ // b.) There are several code paths which are not clear if they would call
+ // this function directly and which would therefore break (e.g.
+ // "Browser::EmailPageLocation" (to name only one).
+ // As such we should keep this code here.
if (url.SchemeIs("mailto")) {
std::string string_url = kGmailComposeUrl;
string_url.append(url.spec());

Powered by Google App Engine
This is Rietveld 408576698