Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1827)

Unified Diff: chrome/browser/platform_util_chromeos.cc

Issue 10139002: Preventing our default handlers for ChromeOS to show up or confuse the user (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Addressing fifth review Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/platform_util_chromeos.cc
diff --git a/chrome/browser/platform_util_chromeos.cc b/chrome/browser/platform_util_chromeos.cc
index eaebafd1c823924b69dcd06f5403c3c1aa22422a..f76f47d31a16dd44ad775dcc5258278876906f45 100644
--- a/chrome/browser/platform_util_chromeos.cc
+++ b/chrome/browser/platform_util_chromeos.cc
@@ -55,6 +55,10 @@ void OpenItem(const FilePath& full_path) {
}
void OpenExternal(const GURL& url) {
+ // TODO(skuhne): This code seems obsolete since we have default handlers on
+ // ChromeOS which should handle this. The simple "mailto" request default
+ // case was handled properly, but it is unclear if there aren't some hidden
+ // cases left.
DaveMoore 2012/04/26 14:45:50 I would rather see us remove this or replace the c
Mr4D (OOO till 08-26) 2012/04/26 16:34:37 Okay, I have changed the comment after reviewing t
if (url.SchemeIs("mailto")) {
std::string string_url = kGmailComposeUrl;
string_url.append(url.spec());

Powered by Google App Engine
This is Rietveld 408576698