Preventing our default handlers for ChromeOS to show up or confuse the user

chrome/browser/custom_handlers/protocol_handler_registry.h

Index: chrome/browser/custom_handlers/protocol_handler_registry.h
diff --git a/chrome/browser/custom_handlers/protocol_handler_registry.h b/chrome/browser/custom_handlers/protocol_handler_registry.h
index edfb7ab6327372f319afaec84e7d5fe26b2650a6..305d6afe4f5882fb07012829d591c9ca79b1aa6e 100644
--- a/chrome/browser/custom_handlers/protocol_handler_registry.h
+++ b/chrome/browser/custom_handlers/protocol_handler_registry.h
@@ -134,6 +134,9 @@ class ProtocolHandlerRegistry
   // registry.
   void GetRegisteredProtocols(std::vector<std::string>* output) const;
 
+  // Returns true if the presented scheme is a build in scheme.
+  bool IsFixedHandler(const std::string& scheme) const;
+
   // Returns true if we allow websites to register handlers for the given
   // scheme.
   bool CanSchemeBeOverridden(const std::string& scheme) const;
@@ -194,6 +197,9 @@ class ProtocolHandlerRegistry
  private:
   friend class base::RefCountedThreadSafe<ProtocolHandlerRegistry>;
 
+  // Install the default handlers.
+  void InstallSystemDefaultHandlers();

[benwells, 2012/04/20 00:25:05]

Can this be called InstallFixedHandlers to be consistent with above? Or
IsFixedHandler to IsSysetmDefaultHandler?

[Mr4D (OOO till 08-26), 2012/04/20 13:44:41]

Done.

+
   // Puts the given handler at the top of the list of handlers for its
   // protocol.
   void PromoteHandler(const ProtocolHandler& handler);
@@ -277,6 +283,10 @@ class ProtocolHandlerRegistry
   // Whether or not we are loading.
   bool is_loading_;
 
+  // Once predefined defaults are set, this will be set and an overwrite of
+  // them won't be possible anymore.
+  bool locking_defaults_;

[benwells, 2012/04/20 00:25:05]

This variable name is confusing. Can it be renamed? Perhaps if you reverse it
you can call it fixed_handlers_loaded_.

[Mr4D (OOO till 08-26), 2012/04/20 13:44:41]

Done.

+
   DefaultClientObserverList default_client_observers_;
 
   // Copy of default_handlers_ that is only accessed on the IO thread.