Preventing our default handlers for ChromeOS to show up or confuse the user

chrome/browser/platform_util_chromeos.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/platform_util.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/file_util.h"
 #include "base/utf_string_conversions.h"
@@ skipping 37 matching lines @@
   file_manager_util::ShowFileInFolder(full_path);
 }
 
 void OpenItem(const FilePath& full_path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
       base::Bind(&OpenItemOnFileThread, full_path));
 }
 
 void OpenExternal(const GURL& url) {
-  if (url.SchemeIs("mailto")) {

[benwells, 2012/04/26 00:34:42]

I know I asked for this change, but ... we discussed it on chat and I thought
had decided to add a TODO.

There are a few callers to OpenExternal (e.g. Browser::EmailPageLocation). Have
you check this won't break any of them?

[Mr4D (OOO till 08-26), 2012/04/26 13:46:35]

Well - I have tried all cases I could come up with and they worked as expected.
However - you are right there might be some other use cases I don't know. So I
was adding it back in and added a comment.

-    std::string string_url = kGmailComposeUrl;
-    string_url.append(url.spec());
-    BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
-                            base::Bind(OpenURL, string_url));
-  }
 }
 
 }  // namespace platform_util