Remove SpdyFramer::CompressFrame() and use CompressControlFrame instead.

Remove SpdyFramer::CompressFrame() and use CompressControlFrame instead.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133496

[Ryan Hamilton, 2012-04-19 21:07:38]

hkhalil: I believe this is what we discussed.  If this works for you, I'll land
the corresponding change server side as well.

[hkhalil, 2012-04-19 21:12:59]

https://chromiumcodereview.appspot.com/10138003/diff/1/net/spdy/spdy_framer.cc
File net/spdy/spdy_framer.cc (right):

https://chromiumcodereview.appspot.com/10138003/diff/1/net/spdy/spdy_framer.c...
net/spdy/spdy_framer.cc:1284: control_frame.type() == HEADERS;
Should probably be a separate change so that it's easier to roll back, track,
etc. Up to you.

https://chromiumcodereview.appspot.com/10138003/diff/1/net/spdy/spdy_framer.c...
net/spdy/spdy_framer.cc:1284: control_frame.type() == HEADERS;
Regression test for this bug?

[Ryan Hamilton, 2012-04-19 21:14:55]

raman: can you take a look
hkhalil: thanks

https://chromiumcodereview.appspot.com/10138003/diff/1/net/spdy/spdy_framer.cc
File net/spdy/spdy_framer.cc (right):

https://chromiumcodereview.appspot.com/10138003/diff/1/net/spdy/spdy_framer.c...
net/spdy/spdy_framer.cc:1284: control_frame.type() == HEADERS;
On 2012/04/19 21:12:59, hkhalil wrote:
> Regression test for this bug?

I added one in spdy_framer_test.cc :>

https://chromiumcodereview.appspot.com/10138003/diff/1/net/spdy/spdy_framer.c...
net/spdy/spdy_framer.cc:1284: control_frame.type() == HEADERS;
On 2012/04/19 21:12:59, hkhalil wrote:
> Should probably be a separate change so that it's easier to roll back, track,
> etc. Up to you.

I think it'll just as easy to do in a single CL since the server side doesn't
have this function at all...

[hkhalil, 2012-04-19 21:15:48]

https://chromiumcodereview.appspot.com/10138003/diff/1/net/spdy/spdy_framer.cc
File net/spdy/spdy_framer.cc (right):

https://chromiumcodereview.appspot.com/10138003/diff/1/net/spdy/spdy_framer.c...
net/spdy/spdy_framer.cc:1284: control_frame.type() == HEADERS;
On 2012/04/19 21:14:55, Ryan Hamilton wrote:
> On 2012/04/19 21:12:59, hkhalil wrote:
> > Regression test for this bug?
> 
> I added one in spdy_framer_test.cc :>

I mean in an end-to-end test...

[ramant (doing other things), 2012-04-19 21:21:57]

lgtm

[hkhalil, 2012-04-19 21:24:39]

lgtm

[commit-bot: I haz the power, 2012-04-23 17:53:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/10138003/19001

[commit-bot: I haz the power, 2012-04-23 19:34:18]

Change committed as 133496