Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 10137011: roll gyp 1342:1344 (Closed)

Created:
8 years, 7 months ago by scottmg
Modified:
8 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

roll gyp 1342:1344 1343: ninja windows: fix expansion of some VS macros 1344: Exclude problematic formats from tests, rather than including all other platforms TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134436

Patch Set 1 #

Patch Set 2 : 1344 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
(small roll since I think that's all that's left for incremental linking)
8 years, 7 months ago (2012-04-27 23:26:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10137011/2001
8 years, 7 months ago (2012-04-27 23:27:29 UTC) #2
Nico
lgtm
8 years, 7 months ago (2012-04-27 23:27:33 UTC) #3
commit-bot: I haz the power
Try job failure for 10137011-2001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-04-27 23:58:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/10137011/2001
8 years, 7 months ago (2012-04-28 00:34:00 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-04-28 03:17:19 UTC) #6
Change committed as 134436

Powered by Google App Engine
This is Rietveld 408576698