Issue 10137006: Allow linux trace events to not be time-shifted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10137006: Allow linux trace events to not be time-shifted. (Closed)

Created:
8 years, 8 months ago by Sam Leffler

Modified:
8 years, 8 months ago

Reviewers:
nduca

CC:
chromium-reviews, tfarina, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Allow linux trace events to not be time-shifted. When importing Linux system events treat a trace_event_clock_sync record with 0 parent timestamp as a noop. While here do the same when the calculated time shift is zero. BUG=none TEST=unit tests (updated for null-shift case) Change-Id: Ifec8ae22bfc7231ee1e22082735df6b389d786b0 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134410

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	chrome/browser/resources/tracing/linux_perf_importer.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	chrome/browser/resources/tracing/linux_perf_importer_test.html	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sleffler@chromium.org/10137006/1

8 years, 8 months ago (2012-04-27 22:14:21 UTC) #3

Change committed as 134410

Expand Messages | Collapse Messages