Replace StreamParserHost interface with callbacks.

Replace StreamParserHost interface with callbacks.


BUG=122909
TEST=Existing ChunkDemuxer tests cover this change.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134020

[annacc, 2012-04-25 20:57:28]

On 2012/04/25 19:55:21, acolwell wrote:

LGTM.  Nice solution.

[scherkus (not reviewing), 2012-04-25 21:01:16]

http://codereview.chromium.org/10134066/diff/1/media/filters/chunk_demuxer.cc
File media/filters/chunk_demuxer.cc (right):

http://codereview.chromium.org/10134066/diff/1/media/filters/chunk_demuxer.cc...
media/filters/chunk_demuxer.cc:364: base::Bind(&ChunkDemuxer::OnNewConfigs,
this),
just as a precautionary FYI for these types of changes...

before we weren't increasing the ref-count when passing in |this|, but
base::Bind() here is adding a ref

this can lead to circular refs / leaks if we're not careful

[acolwell GONE FROM CHROMIUM, 2012-04-25 22:17:01]

http://codereview.chromium.org/10134066/diff/1/media/filters/chunk_demuxer.cc
File media/filters/chunk_demuxer.cc (right):

http://codereview.chromium.org/10134066/diff/1/media/filters/chunk_demuxer.cc...
media/filters/chunk_demuxer.cc:364: base::Bind(&ChunkDemuxer::OnNewConfigs,
this),
On 2012/04/25 21:01:17, scherkus wrote:
> just as a precautionary FYI for these types of changes...
> 
> before we weren't increasing the ref-count when passing in |this|, but
> base::Bind() here is adding a ref
> 
> this can lead to circular refs / leaks if we're not careful

Good point. I've added base::Unretained so the code matches the original
ref-counting.

[commit-bot: I haz the power, 2012-04-25 22:17:30]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[scherkus (not reviewing), 2012-04-25 22:29:34]

lgtm

[commit-bot: I haz the power, 2012-04-25 22:33:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/10134066/8001

[commit-bot: I haz the power, 2012-04-26 00:11:59]

Change committed as 134020