Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 10134040: Add keybindings and webRequest examples to the transient background page (Closed)

Created:
8 years, 8 months ago by Matt Perry
Modified:
8 years, 8 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, pam+watch_chromium.org, mihaip+watch_chromium.org
Visibility:
Public.

Description

Add keybindings and webRequest examples to the transient background page example. BUG=no TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133823

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -5 lines) Patch
M chrome/common/extensions/docs/examples/api/cookies.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/devtools/network/chrome-firephp.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/transientPage/basic.zip View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/common/extensions/docs/examples/api/transientPage/basic/background.js View 2 chunks +14 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/examples/api/transientPage/basic/manifest.json View 2 chunks +10 lines, -1 line 2 comments Download
M chrome/common/extensions/docs/samples.html View 3 chunks +10 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/samples.json View 5 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Matt Perry
8 years, 8 months ago (2012-04-24 21:02:44 UTC) #1
Yoyo Zhou
LGTM http://codereview.chromium.org/10134040/diff/1/chrome/common/extensions/docs/examples/api/transientPage/basic/manifest.json File chrome/common/extensions/docs/examples/api/transientPage/basic/manifest.json (right): http://codereview.chromium.org/10134040/diff/1/chrome/common/extensions/docs/examples/api/transientPage/basic/manifest.json#newcode6 chrome/common/extensions/docs/examples/api/transientPage/basic/manifest.json:6: "permissions": ["tabs", "bookmarks", "experimental", "keybinding", "http://*.google.com/*"], This is ...
8 years, 8 months ago (2012-04-24 21:38:14 UTC) #2
Matt Perry
http://codereview.chromium.org/10134040/diff/1/chrome/common/extensions/docs/examples/api/transientPage/basic/manifest.json File chrome/common/extensions/docs/examples/api/transientPage/basic/manifest.json (right): http://codereview.chromium.org/10134040/diff/1/chrome/common/extensions/docs/examples/api/transientPage/basic/manifest.json#newcode6 chrome/common/extensions/docs/examples/api/transientPage/basic/manifest.json:6: "permissions": ["tabs", "bookmarks", "experimental", "keybinding", "http://*.google.com/*"], On 2012/04/24 21:38:15, ...
8 years, 8 months ago (2012-04-24 22:37:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/10134040/1
8 years, 8 months ago (2012-04-24 22:37:36 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 00:42:18 UTC) #5
Change committed as 133823

Powered by Google App Engine
This is Rietveld 408576698