Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7090)

Unified Diff: chrome/browser/ui/browser.cc

Issue 10134036: Let Chrome app handle Ash accelerators first if the app is launched as a window (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix tests Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index e2d6613ca02fd3bfca973c122df777b9ccc9622e..cf6b8426f90a27a9e67c909469a6ed45a5e30d7d 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -2663,6 +2663,10 @@ bool Browser::ExecuteCommandIfEnabled(int id) {
bool Browser::IsReservedCommandOrKey(int command_id,
const NativeWebKeyboardEvent& event) {
+ // In Apps mode, no keys are reserved.
+ if (is_app())
+ return false;
+
#if defined(OS_CHROMEOS)
// Chrome OS's top row of keys produces F1-10. Make sure that web pages
// aren't able to block Chrome from performing the standard actions for F1-F4
@@ -2685,10 +2689,6 @@ bool Browser::IsReservedCommandOrKey(int command_id,
}
#endif
- // In Apps mode, no keys are reserved.
- if (is_app())
- return false;
-
if (window_->IsFullscreen() && command_id == IDC_FULLSCREEN)
return true;
return command_id == IDC_CLOSE_TAB ||

Powered by Google App Engine
This is Rietveld 408576698