Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3422)

Unified Diff: chrome/browser/chromeos/cros/cros_network_functions_unittest.cc

Issue 10134028: Reimplement ActivateCellularModem without Libcros (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add crosbug.com URLs to TODO comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros/cros_network_functions_unittest.cc
diff --git a/chrome/browser/chromeos/cros/cros_network_functions_unittest.cc b/chrome/browser/chromeos/cros/cros_network_functions_unittest.cc
index 5a00814864912e5be7c11812d954ef11299cdc76..1037581eaf22e8e0f97712b3e984378d6f5488af 100644
--- a/chrome/browser/chromeos/cros/cros_network_functions_unittest.cc
+++ b/chrome/browser/chromeos/cros/cros_network_functions_unittest.cc
@@ -185,6 +185,15 @@ class CrosNetworkFunctionsLibcrosTest : public testing::Test {
const GValue* gvalue)> property_changed_callback_;
};
+TEST_F(CrosNetworkFunctionsLibcrosTest, CrosActivateCellularModem) {
+ const std::string service_path = "/";
+ const std::string carrier = "carrier";
+ EXPECT_CALL(*MockChromeOSNetwork::Get(),
+ ActivateCellularModem(StrEq(service_path), StrEq(carrier)))
+ .Times(1);
+ CrosActivateCellularModem(service_path, carrier);
+}
+
TEST_F(CrosNetworkFunctionsLibcrosTest, CrosSetNetworkServiceProperty) {
const std::string service_path = "/";
const std::string property = "property";
@@ -732,6 +741,16 @@ class CrosNetworkFunctionsTest : public testing::Test {
const base::DictionaryValue* dictionary_value_result_;
};
+TEST_F(CrosNetworkFunctionsTest, CrosActivateCellularModem) {
+ const std::string service_path = "/";
+ const std::string carrier = "carrier";
+ EXPECT_CALL(*mock_service_client_,
+ CallActivateCellularModemAndBlock(dbus::ObjectPath(service_path),
+ carrier))
+ .WillOnce(Return(true));
+ EXPECT_TRUE(CrosActivateCellularModem(service_path, carrier));
+}
+
TEST_F(CrosNetworkFunctionsTest, CrosSetNetworkServiceProperty) {
const std::string service_path = "/";
const std::string property = "property";
« no previous file with comments | « chrome/browser/chromeos/cros/cros_network_functions.cc ('k') | chrome/browser/chromeos/cros/mock_chromeos_network.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698