Add bind(), recvFrom(), sendTo() for UDP socket.

chrome/browser/extensions/api/socket/udp_socket_unittest.cc

Index: chrome/browser/extensions/api/socket/udp_socket_unittest.cc
diff --git a/chrome/browser/extensions/api/socket/udp_socket_unittest.cc b/chrome/browser/extensions/api/socket/udp_socket_unittest.cc
index b8c50a1d8e68ef99621b254d0cd257a9bf431074..acd31958c1d8b9f097c06902594e5b1451ed98a0 100644
--- a/chrome/browser/extensions/api/socket/udp_socket_unittest.cc
+++ b/chrome/browser/extensions/api/socket/udp_socket_unittest.cc
@@ -10,7 +10,7 @@
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
 #include "net/base/rand_callback.h"
-#include "net/udp/udp_client_socket.h"
+#include "net/udp/udp_socket.h"
 #include "testing/gmock/include/gmock/gmock.h"
 
 using testing::_;
@@ -19,14 +19,15 @@ using testing::Return;
 using testing::SaveArg;
 
 namespace extensions {
-
-class MockUDPSocket : public net::UDPClientSocket {
+// TODO(penghuang): Re-enable UDPSocket unit test
+#if 0

[miket_OOO, 2012/04/23 22:23:40]

Same here. Why not now?

[Peng, 2012/04/24 15:07:14]

It is impossible to reuse those UDP tests. Because methods of net::UDPSocket are
not virtual methods. We can not test those functions by creating a
MockUDPSocket. Do you have good ideas?

[miket_OOO, 2012/04/24 18:13:56]

Can you make them virtual?

[Peng, 2012/04/24 20:31:38]

Yes. But it seems a little expensive to make them virtual only because of
testing. And I removed the Socket::socket() virtual function and implementations
of Socket::Read() and Socket::Write() in Socket class. So maybe the tests are
not very necessary anymore. What do you think?

[miket_OOO, 2012/04/24 20:49:05]

If you think so, then delete them rather than #if 0'ing them out.

+class MockUDPSocket : public net::UDPSocket {
  public:
   MockUDPSocket()
-      : net::UDPClientSocket(net::DatagramSocket::DEFAULT_BIND,
-                             net::RandIntCallback(),
-                             NULL,
-                             net::NetLog::Source()) {}
+      : net::UDPSocket(net::DatagramSocket::DEFAULT_BIND,
+                       net::RandIntCallback(),
+                       NULL,
+                       net::NetLog::Source()) {}
 
   MOCK_METHOD3(Read, int(net::IOBuffer* buf, int buf_len,
                          const net::CompletionCallback& callback));
@@ -52,7 +53,7 @@ TEST(SocketTest, TestUDPSocketRead) {
   APIResourceEventNotifier* notifier = new MockAPIResourceEventNotifier();
 
   scoped_ptr<UDPSocket> socket(UDPSocket::CreateSocketForTesting(
-      udp_client_socket, "1.2.3.4", 1, notifier));
+      udp_client_socket, notifier));
 
   EXPECT_CALL(*udp_client_socket, Read(_, _, _))
       .Times(1);
@@ -67,7 +68,7 @@ TEST(SocketTest, TestUDPSocketWrite) {
   APIResourceEventNotifier* notifier = new MockAPIResourceEventNotifier();
 
   scoped_ptr<UDPSocket> socket(UDPSocket::CreateSocketForTesting(
-      udp_client_socket, "1.2.3.4", 1, notifier));
+      udp_client_socket, notifier));
 
   EXPECT_CALL(*udp_client_socket, Write(_, _, _))
       .Times(1);
@@ -82,7 +83,7 @@ TEST(SocketTest, TestUDPSocketBlockedWrite) {
   MockAPIResourceEventNotifier* notifier = new MockAPIResourceEventNotifier();
 
   scoped_ptr<UDPSocket> socket(UDPSocket::CreateSocketForTesting(
-      udp_client_socket, "1.2.3.4", 1, notifier));
+      udp_client_socket, notifier));
 
   net::CompletionCallback callback;
   EXPECT_CALL(*udp_client_socket, Write(_, _, _))
@@ -100,5 +101,5 @@ TEST(SocketTest, TestUDPSocketBlockedWrite) {
       .Times(1);
   callback.Run(42);
 }
-
+#endif
 }  // namespace extensions