chrome/browser/metrics/metrics_service.cc - Issue 10127009: Make NameValuePairsParser support values that contain the 'equal' separator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 10127009: Make NameValuePairsParser support values that contain the 'equal' separator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix typo Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/metrics/metrics_service.cc

diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc

index 25d0af77d158de0edcca51d289e3e5d91efe5b60..a99849e4b4499ab3588364647538966a27997d00 100644

--- a/chrome/browser/metrics/metrics_service.cc

+++ b/chrome/browser/metrics/metrics_service.cc

@@ -764,6 +764,8 @@ void MetricsService::InitTaskGetHardwareClass(

#if defined(OS_CHROMEOS)

chromeos::system::StatisticsProvider::GetInstance()->GetMachineStatistic(

"hardware_class", &hardware_class);

+ if (hardware_class.empty())

petkov 2012/04/23 09:34:06 You could use LOG_IF instead.

Joao da Silva 2012/04/23 09:50:06 Another CL (http://codereview.chromium.org/1007801

+ LOG(ERROR) << "Got an empty hardware_class!";

#endif // OS_CHROMEOS

target_loop->PostTask(FROM_HERE,

« chrome/browser/chromeos/system/name_value_pairs_parser.cc ('K') | « chrome/browser/chromeos/system/udev_info_provider.cc ('k') | no next file » | no next file with comments »