Make NameValuePairsParser support values that contain the 'equal' separator.

chrome/browser/metrics/metrics_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 //------------------------------------------------------------------------------
 // Description of the life cycle of a instance of MetricsService.
 //
 //  OVERVIEW
 //
 // A MetricsService instance is typically created at application startup.  It
@@ skipping 746 matching lines @@
 // static
 void MetricsService::InitTaskGetHardwareClass(
     base::WeakPtr<MetricsService> self,
     base::MessageLoopProxy* target_loop) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
 
   std::string hardware_class;
 #if defined(OS_CHROMEOS)
   chromeos::system::StatisticsProvider::GetInstance()->GetMachineStatistic(
       "hardware_class", &hardware_class);
+  if (hardware_class.empty())

[petkov, 2012/04/23 09:34:06]

You could use LOG_IF instead.

[Joao da Silva, 2012/04/23 09:50:06]

Another CL (http://codereview.chromium.org/10078017/) makes other changes to
metrics_service.cc such that this is now unnecessary. I've removed these lines.

+    LOG(ERROR) << "Got an empty hardware_class!";
 #endif  // OS_CHROMEOS
 
   target_loop->PostTask(FROM_HERE,
       base::Bind(&MetricsService::OnInitTaskGotHardwareClass,
           self, hardware_class));
 }
 
 void MetricsService::OnInitTaskGotHardwareClass(
     const std::string& hardware_class) {
   DCHECK_EQ(state_, INIT_TASK_SCHEDULED);
@@ skipping 893 matching lines @@
   if (local_state) {
     const PrefService::Preference* uma_pref =
         local_state->FindPreference(prefs::kMetricsReportingEnabled);
     if (uma_pref) {
       bool success = uma_pref->GetValue()->GetAsBoolean(&result);
       DCHECK(success);
     }
   }
   return result;
 }