Make NameValuePairsParser support values that contain the 'equal' separator.

chrome/browser/chromeos/system/statistics_provider.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/system/statistics_provider.h"
 
 #include "base/bind.h"
 #include "base/chromeos/chromeos_version.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
@@ skipping 90 matching lines @@
   //
   // If you see the warning appeared for regular sessions, it probably
   // means that there is new client code that uses the statistics in the
   // very early stage of the browser startup. The statistic name should be
   // helpful to identify the caller.
   if (!on_statistics_loaded_.IsSignaled()) {
     LOG(WARNING) << "Waiting to load statistics. Requested statistic: "
                  << name;
     on_statistics_loaded_.TimedWait(base::TimeDelta::FromSeconds(kTimeoutSecs));
   }
 

[petkov, 2012/04/19 13:47:01]

It might be a good idea to add another warning here if on_statistics_loaded_ is
not signaled yet. Somebody pasted some logs where we get two instances in a row
of the warning above which means that we lookup the map too early at least once.

Alternatively (or additionally), we should probably log a warning in
MetricsService::InitTaskGetHardwareClass if hardware_class_ is empty.

[1404:1404:5640558:ERROR:ownership_service.cc(80)] Blocking on UI thread in
OwnershipService::GetStatus
[1404:1433:5692610:WARNING:statistics_provider.cc(99)] Waiting to load
statistics. Requested statistic: hardware_class
[1404:1404:6021123:WARNING:statistics_provider.cc(99)] Waiting to load
statistics. Requested statistic: hardware_class
[1404:1433:8705821:WARNING:name_value_pairs_parser.cc(123)] Unable to read
statistics file: /tmp/machine-info
[1404:1404:8706558:ERROR:browser_policy_connector.cc(439)] Failed to get machine
serial number.
[1404:1433:8841407:ERROR:nss_util.cc(482)] Error initializing NSS with a
persistent database (sql:/etc/fake_root_ca/nssdb): NSS error code: -8174

[Joao da Silva, 2012/04/19 16:01:30]

Done.
Also done.

   NameValuePairsParser::NameValueMap::iterator iter = machine_info_.find(name);
   if (iter != machine_info_.end()) {
     *result = iter->second;
     return true;
   }
   return false;
 }
 
 // manual_reset needs to be true, as we want to keep the signaled state.
 StatisticsProviderImpl::StatisticsProviderImpl()
@@ skipping 10 matching lines @@
       BrowserThread::FILE,
       FROM_HERE,
       base::Bind(&StatisticsProviderImpl::LoadMachineStatistics,
                  base::Unretained(this)));
 }
 
 void StatisticsProviderImpl::LoadMachineStatistics() {
   NameValuePairsParser parser(&machine_info_);
 
   // Parse all of the key/value pairs from the crossystem tool.
-  parser.ParseNameValuePairsFromTool(
-      arraysize(kCrosSystemTool), kCrosSystemTool, kCrosSystemEq,
-      kCrosSystemDelim, kCrosSystemCommentDelim);
+  if (!parser.ParseNameValuePairsFromTool(
+          arraysize(kCrosSystemTool), kCrosSystemTool, kCrosSystemEq,
+          kCrosSystemDelim, kCrosSystemCommentDelim)) {
+    LOG(WARNING) << "There were errors parsing the output of "
+                 << kCrosSystemTool << ".";
+  }
 
   // Ensure that the hardware class key is present with the expected
   // key name, and if it couldn't be retrieved, that the value is "unknown".
   std::string hardware_class = machine_info_[kHardwareClassCrosSystemKey];
   if (hardware_class.empty() || hardware_class == kCrosSystemUnknownValue)
     machine_info_[kHardwareClassKey] = kUnknownHardwareClass;
   else
     machine_info_[kHardwareClassKey] = hardware_class;
 
   parser.GetNameValuePairsFromFile(FilePath(kMachineHardwareInfoFile),
@@ skipping 66 matching lines @@
 StatisticsProvider* StatisticsProvider::GetInstance() {
   if (base::chromeos::IsRunningOnChromeOS()) {
     return StatisticsProviderImpl::GetInstance();
   } else {
     return StatisticsProviderStubImpl::GetInstance();
   }
 }
 
 }  // namespace system
 }  // namespace chromeos