Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: webkit/fileapi/local_file_writer.cc

Issue 10126004: fileapi: FileWriter and LocalFileWriter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Drop Seek(), loosen Cancel() and destructor's requirements, and add constuctor parameters. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/fileapi/local_file_writer.cc
diff --git a/webkit/fileapi/local_file_writer.cc b/webkit/fileapi/local_file_writer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8721ccf433931a914b1787b225b0813440b43d4d
--- /dev/null
+++ b/webkit/fileapi/local_file_writer.cc
@@ -0,0 +1,192 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "webkit/fileapi/local_file_writer.h"
+
+#include "base/callback.h"
+#include "base/message_loop.h"
+#include "net/base/file_stream.h"
+#include "net/base/io_buffer.h"
+
+namespace fileapi {
+
+namespace {
+
+const int kOpenFlagsForWrite = base::PLATFORM_FILE_OPEN |
+ base::PLATFORM_FILE_WRITE |
+ base::PLATFORM_FILE_ASYNC;
+
+const int kOpenFlagsForCreate = base::PLATFORM_FILE_CREATE_ALWAYS |
+ base::PLATFORM_FILE_WRITE |
+ base::PLATFORM_FILE_ASYNC;
+
+} // namespace
+
+LocalFileWriter::LocalFileWriter(const FilePath& file_path,
+ int64 initial_offset,
+ FileOpenMode mode)
+ : file_path_(file_path),
+ file_open_flags_(mode == CREATE ? kOpenFlagsForCreate
+ : kOpenFlagsForWrite),
+ initial_offset_(initial_offset),
+ has_pending_operation_(false),
+ weak_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(this)) {}
+
+LocalFileWriter::~LocalFileWriter() {
+ // Invalidate weak pointers so that we won't receive any callbacks from
+ // in-flight stream operations, which might be triggered during the file close
+ // in the FileStream destructor.
+ weak_factory_.InvalidateWeakPtrs();
+
+ // FileStream's destructor closes the file safely, since we opened the file
+ // by its Open() method.
+}
+
+int LocalFileWriter::Write(net::IOBuffer* buf, int buf_len,
+ const net::CompletionCallback& callback) {
+ DCHECK(!has_pending_operation_);
+ DCHECK(cancel_callback_.is_null());
+
+ has_pending_operation_ = true;
+ if (stream_impl_.get()) {
+ int result = InitiateWrite(buf, buf_len, callback);
+ if (result != net::ERR_IO_PENDING)
+ has_pending_operation_ = false;
+ return result;
+ }
+ return InitiateOpen(callback,
+ base::Bind(&LocalFileWriter::ReadyToWrite,
+ weak_factory_.GetWeakPtr(),
+ make_scoped_refptr(buf), buf_len, callback));
+}
+
+void LocalFileWriter::Cancel(const net::CompletionCallback& callback) {
+ if (!has_pending_operation_) {
+ MessageLoop::current()->PostTask(FROM_HERE,
+ base::Bind(callback, net::ERR_FAILED));
+ return;
+ }
+
+ DCHECK(!callback.is_null());
+ cancel_callback_ = callback;
+}
+
+int LocalFileWriter::InitiateOpen(const net::CompletionCallback& error_callback,
+ const base::Closure& main_operation) {
+ DCHECK(has_pending_operation_);
+ DCHECK(!stream_impl_.get());
+
+ stream_impl_.reset(new net::FileStream(NULL));
+ return stream_impl_->Open(file_path_,
+ file_open_flags_,
+ base::Bind(&LocalFileWriter::DidOpen,
+ weak_factory_.GetWeakPtr(),
+ error_callback,
+ main_operation));
+}
+
+void LocalFileWriter::DidOpen(const net::CompletionCallback& error_callback,
+ const base::Closure& main_operation,
+ int result) {
+ DCHECK(has_pending_operation_);
+ DCHECK(stream_impl_.get());
+
+ if (CancelIfRequested())
+ return;
+
+ if (result != net::OK) {
+ has_pending_operation_ = false;
+ stream_impl_.reset(NULL);
+ error_callback.Run(result);
+ return;
+ }
+
+ InitiateSeek(error_callback, main_operation);
+}
+
+void LocalFileWriter::InitiateSeek(
+ const net::CompletionCallback& error_callback,
+ const base::Closure& main_operation) {
+ DCHECK(has_pending_operation_);
+ DCHECK(stream_impl_.get());
+
+ if (initial_offset_ == 0) {
+ // No need to seek.
+ main_operation.Run();
kinuko 2012/04/23 09:29:57 nit: could we return here earlier?
kinaba 2012/04/23 10:55:14 Done.
+ } else {
+ int result = stream_impl_->Seek(net::FROM_BEGIN, initial_offset_,
+ base::Bind(&LocalFileWriter::DidSeek,
+ weak_factory_.GetWeakPtr(),
+ error_callback,
+ main_operation));
+ if (result != net::ERR_IO_PENDING) {
+ has_pending_operation_ = false;
+ error_callback.Run(result);
+ }
+ }
+}
+
+void LocalFileWriter::DidSeek(const net::CompletionCallback& error_callback,
+ const base::Closure& main_operation,
+ int64 result) {
+ DCHECK(has_pending_operation_);
+
+ if (CancelIfRequested())
+ return;
+
+ if (result < 0) {
+ has_pending_operation_ = false;
+ error_callback.Run(static_cast<int>(result));
+ return;
+ }
+
kinuko 2012/04/23 09:29:57 Seek returns the new offset and in most cases we'd
kinaba 2012/04/23 10:55:14 Modified to check the equality and to return net::
+ main_operation.Run();
+}
+
+void LocalFileWriter::ReadyToWrite(net::IOBuffer* buf, int buf_len,
+ const net::CompletionCallback& callback) {
+ DCHECK(has_pending_operation_);
+
+ int result = InitiateWrite(buf, buf_len, callback);
+ if (result != net::ERR_IO_PENDING) {
+ has_pending_operation_ = false;
+ callback.Run(result);
+ }
+}
+
+int LocalFileWriter::InitiateWrite(net::IOBuffer* buf, int buf_len,
+ const net::CompletionCallback& callback) {
+ DCHECK(has_pending_operation_);
+ DCHECK(stream_impl_.get());
+
+ return stream_impl_->Write(buf, buf_len,
+ base::Bind(&LocalFileWriter::DidWrite,
+ weak_factory_.GetWeakPtr(),
+ callback));
+}
+
+void LocalFileWriter::DidWrite(const net::CompletionCallback& callback,
+ int result) {
+ DCHECK(has_pending_operation_);
+
+ if (CancelIfRequested())
+ return;
+ has_pending_operation_ = false;
+ callback.Run(result);
+}
+
+bool LocalFileWriter::CancelIfRequested() {
+ DCHECK(has_pending_operation_);
+
+ if (cancel_callback_.is_null())
+ return false;
+
+ net::CompletionCallback pending_cancel = cancel_callback_;
+ has_pending_operation_ = false;
+ cancel_callback_.Reset();
+ pending_cancel.Run(net::OK);
+ return true;
+}
+
+} // namespace fileapi

Powered by Google App Engine
This is Rietveld 408576698