Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 10125007: Don't infobar plug-ins when they're whitelisted via chrome://plugins. (Closed)

Created:
8 years, 8 months ago by Bernhard Bauer
Modified:
8 years, 8 months ago
Reviewers:
marja
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Don't infobar plug-ins when they're whitelisted via chrome://plugins. BUG=117236 TEST=see bug for manual test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/renderer_host/plugin_info_message_filter.cc View 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Bernhard Bauer
Please review.
8 years, 8 months ago (2012-04-20 12:39:01 UTC) #1
marja
lgtm
8 years, 8 months ago (2012-04-20 12:45:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10125007/1
8 years, 8 months ago (2012-04-20 12:51:48 UTC) #3
commit-bot: I haz the power
Try job failure for 10125007-1 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-20 14:08:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10125007/1
8 years, 8 months ago (2012-04-23 07:39:12 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 08:47:21 UTC) #6
Change committed as 133412

Powered by Google App Engine
This is Rietveld 408576698