sync/protocol/proto_value_conversions.cc - Issue 10125002: [Sync] Add per-navigation timestamps/unique ids to tab sync.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/protocol/proto_value_conversions.cc

Issue 10125002: [Sync] Add per-navigation timestamps/unique ids to tab sync. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/protocol/proto_value_conversions.cc

diff --git a/sync/protocol/proto_value_conversions.cc b/sync/protocol/proto_value_conversions.cc

index 472626c0508d6a6d03561420c2291ccb83d43e25..70b3ea13496e48de50d71e47a3a30bcfe8851af8 100644

--- a/sync/protocol/proto_value_conversions.cc

+++ b/sync/protocol/proto_value_conversions.cc

@@ -157,13 +157,14 @@ DictionaryValue* SessionWindowToValue(

DictionaryValue* TabNavigationToValue(

const sync_pb::TabNavigation& proto) {

DictionaryValue* value = new DictionaryValue();

- SET_INT32(index);

SET_STR(virtual_url);

SET_STR(referrer);

SET_STR(title);

SET_STR(state);

SET_ENUM(page_transition, GetPageTransitionString);

SET_ENUM(navigation_qualifier, GetPageTransitionQualifierString);

+ SET_INT32(unique_id);

+ SET_INT64(timestamp);

return value;

}