Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 10122007: Session restore: Use the same TabLoader for all profiles. (Closed)

Created:
8 years, 8 months ago by marja
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, marja+watch_chromium.org
Visibility:
Public.

Description

Session restore: Use the same TabLoader for all profiles. When several profiles are restored at the same time, this decreases the number of tabs loading in parallel. BUG=124235 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133411

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : Code review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -22 lines) Patch
M chrome/browser/sessions/session_restore.cc View 1 2 10 chunks +61 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
marja
ptal
8 years, 8 months ago (2012-04-20 09:38:11 UTC) #1
sky
LGTM http://codereview.chromium.org/10122007/diff/5001/chrome/browser/sessions/session_restore.cc File chrome/browser/sessions/session_restore.cc (right): http://codereview.chromium.org/10122007/diff/5001/chrome/browser/sessions/session_restore.cc#newcode76 chrome/browser/sessions/session_restore.cc:76: // loading, it drops the reference. If another ...
8 years, 8 months ago (2012-04-20 15:39:29 UTC) #2
marja
Thanks for review! http://codereview.chromium.org/10122007/diff/5001/chrome/browser/sessions/session_restore.cc File chrome/browser/sessions/session_restore.cc (right): http://codereview.chromium.org/10122007/diff/5001/chrome/browser/sessions/session_restore.cc#newcode76 chrome/browser/sessions/session_restore.cc:76: // loading, it drops the reference. ...
8 years, 8 months ago (2012-04-23 07:34:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/10122007/10001
8 years, 8 months ago (2012-04-23 07:34:14 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 08:39:42 UTC) #5
Change committed as 133411

Powered by Google App Engine
This is Rietveld 408576698