Implement PepperPacketSocketFactory.

remoting/client/plugin/pepper_packet_socket_factory.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/client/plugin/pepper_packet_socket_factory.h"
+
+#include "base/bind.h"
+#include "base/logging.h"
+#include "net/base/io_buffer.h"
+#include "ppapi/cpp/private/net_address_private.h"
+#include "ppapi/cpp/private/udp_socket_private.h"
+#include "remoting/client/plugin/pepper_util.h"
+#include "third_party/libjingle/source/talk/base/asyncpacketsocket.h"
+
+namespace remoting {
+
+namespace {
+
+// Size of the buffer to allocate for RecvFrom().
+const int kReceiveBufferSize = 65536;
+
+// Maximum amount of data in the send buffers. This is necessary to
+// prevent form out-of-memory crashes when the UDP API stops sending

[Wez, 2012/04/25 01:05:33]

nit: Suggest "This prevents OOM crashes if the caller sends data faster than
Pepper's UDP API can handle it."

[Sergey Ulanov, 2012/04/25 01:21:57]

Done.

+// data. Normally this maximum should never be reached.
+const int kMaxSendBufferSize = 256 * 1024;
+
+class UdpPacketSocket : public talk_base::AsyncPacketSocket {
+ public:
+  explicit UdpPacketSocket(const pp::InstanceHandle& instance);
+  virtual ~UdpPacketSocket();
+
+  // Always takes ownership of client even if initialization fails.

[Wez, 2012/04/25 01:05:33]

Not sure what this means?

[Sergey Ulanov, 2012/04/25 01:21:57]

Removed comment - it was copy-pasted from IpcPacketSocket.

+  bool Init(const talk_base::SocketAddress& local_address,
+            int min_port,
+            int max_port);
+
+  // talk_base::AsyncPacketSocket interface.
+  virtual talk_base::SocketAddress GetLocalAddress() const;
+  virtual talk_base::SocketAddress GetRemoteAddress() const;
+  virtual int Send(const void* data, size_t data_size);
+  virtual int SendTo(const void* data,
+                     size_t data_size,
+                     const talk_base::SocketAddress& address);
+  virtual int Close();
+  virtual State GetState() const;
+  virtual int GetOption(talk_base::Socket::Option opt, int* value);
+  virtual int SetOption(talk_base::Socket::Option opt, int value);
+  virtual int GetError() const;
+  virtual void SetError(int error);
+
+ private:
+  struct PendingPacket {
+    PendingPacket(const void* buffer,
+                  int buffer_size,
+                  const PP_NetAddress_Private& address);
+
+    scoped_refptr<net::IOBufferWithSize> data;
+    PP_NetAddress_Private address;
+  };
+
+  void OnBindCompleted(int error);
+
+  void DoSend();
+  void OnSendCompleted(int result);
+
+  void DoRead();
+  void OnReadCompleted(int result);
+  void HandleReadResult(int result);
+
+  pp::UDPSocketPrivate socket_;
+
+  State state_;
+  int error_;
+
+  talk_base::SocketAddress local_address_;
+
+  // Used to scan ports when part range is specified. Set to 0 when

[Wez, 2012/04/25 01:05:33]

typo: part -> port

[Sergey Ulanov, 2012/04/25 01:21:57]

Done.

+  // the port range is not specified.
+  uint16_t min_port_;
+  uint16_t max_port_;
+
+  std::vector<char> receive_buffer_;
+
+  bool send_pending_;
+  std::list<PendingPacket> send_queue_;
+  int send_queue_size_;
+
+  DISALLOW_COPY_AND_ASSIGN(UdpPacketSocket);
+};
+
+UdpPacketSocket::PendingPacket::PendingPacket(
+    const void* buffer,
+    int buffer_size,
+    const PP_NetAddress_Private& address)
+    : data(new net::IOBufferWithSize(buffer_size)),
+      address(address) {
+  memcpy(data->data(), buffer, buffer_size);
+}
+
+UdpPacketSocket::UdpPacketSocket(const pp::InstanceHandle& instance)
+    : socket_(instance),
+      state_(STATE_CLOSED),
+      error_(0),
+      min_port_(0),
+      max_port_(0),
+      send_pending_(false),
+      send_queue_size_(0) {
+}
+
+UdpPacketSocket::~UdpPacketSocket() {
+  Close();
+}
+
+bool SocketAddressToPpAddressWithPort(const talk_base::SocketAddress& address,
+                                      PP_NetAddress_Private* pp_address,
+                                      uint16_t port) {
+  bool result;

[Wez, 2012/04/25 01:05:33]

Initialize result. Surprised clang didn't catch this.

[Sergey Ulanov, 2012/04/25 01:21:57]

Done.

+  switch(address.ipaddr().family()) {
+    case AF_INET: {
+      in_addr addr = address.ipaddr().ipv4_address();
+      result = pp::NetAddressPrivate::CreateFromIPv4Address(
+          reinterpret_cast<uint8_t*>(&addr), port, pp_address);
+      break;
+    }
+    case AF_INET6: {
+      in6_addr addr = address.ipaddr().ipv6_address();
+      result = pp::NetAddressPrivate::CreateFromIPv6Address(
+          addr.s6_addr, 0, port, pp_address);
+      break;
+    }
+    default: {
+      LOG(WARNING) << "Unknown address family: " << address.ipaddr().family();
+    }
+  }
+  if (!result) {
+    LOG(WARNING) << "Failed to convert address: " << address.ToString();
+  }
+  return result;
+}
+
+bool SocketAddressToPpAddress(const talk_base::SocketAddress& address,
+                              PP_NetAddress_Private* pp_address) {
+  return SocketAddressToPpAddressWithPort(address, pp_address, address.port());
+}
+
+bool PpAddressToSocketAddress(const PP_NetAddress_Private& pp_address,
+                              talk_base::SocketAddress* address) {
+  uint8_t addr_storage[16];
+  bool result = pp::NetAddressPrivate::GetAddress(
+      pp_address, &addr_storage, sizeof(addr_storage));
+
+  if (result) {
+    switch (pp::NetAddressPrivate::GetFamily(pp_address)) {
+      case PP_NETADDRESSFAMILY_IPV4:
+        address->SetIP(talk_base::IPAddress(
+            *reinterpret_cast<in_addr*>(addr_storage)));
+        break;
+      case PP_NETADDRESSFAMILY_IPV6:
+        address->SetIP(talk_base::IPAddress(
+            *reinterpret_cast<in6_addr*>(addr_storage)));
+        break;
+      default:
+        result = false;
+    }
+  }
+
+  if (!result) {
+    LOG(WARNING) << "Failed to convert address: "
+                 << pp::NetAddressPrivate::Describe(pp_address, true);
+  } else {
+    address->SetPort(pp::NetAddressPrivate::GetPort(pp_address));
+  }
+  return result;
+}
+
+bool UdpPacketSocket::Init(const talk_base::SocketAddress& local_address,
+                           int min_port,
+                           int max_port) {
+  if (socket_.is_null()) {
+    return false;
+  }
+
+  local_address_ = local_address;
+  max_port_ = max_port;
+  min_port_ = min_port;
+
+  PP_NetAddress_Private pp_local_address;
+  if (!SocketAddressToPpAddressWithPort(local_address_, &pp_local_address,
+                                        min_port_)) {
+    return false;
+  }
+
+  int result = socket_.Bind(&pp_local_address, PpCompletionCallback(
+      base::Bind(&UdpPacketSocket::OnBindCompleted, base::Unretained(this))));
+  DCHECK_EQ(result, PP_OK_COMPLETIONPENDING);
+  state_ = STATE_BINDING;
+
+  return true;
+}
+
+void UdpPacketSocket::OnBindCompleted(int result) {
+  DCHECK(state_ == STATE_BINDING || state_ == STATE_CLOSED);
+
+  if (result == PP_ERROR_ABORTED) {
+    // Socket is being destroyed while binding.
+    return;
+  }
+
+  if (result == PP_OK) {
+    PP_NetAddress_Private address;
+    if (socket_.GetBoundAddress(&address)) {
+      PpAddressToSocketAddress(address, &local_address_);
+    } else {
+      LOG(ERROR) << "Failed to get bind address for bound socket?";
+      error_ = EINVAL;
+      return;
+    }
+    state_ = STATE_BOUND;
+    SignalAddressReady(this, local_address_);
+    DoRead();
+    return;
+  }
+
+  if (min_port_ < max_port_) {
+    // Try to bind to the next available port.
+    ++min_port_;
+    PP_NetAddress_Private pp_local_address;
+    if (SocketAddressToPpAddressWithPort(local_address_, &pp_local_address,
+                                         min_port_)) {
+      int result = socket_.Bind(&pp_local_address, PpCompletionCallback(
+          base::Bind(&UdpPacketSocket::OnBindCompleted,
+                     base::Unretained(this))));
+      DCHECK_EQ(result, PP_OK_COMPLETIONPENDING);
+    }
+  } else {
+    LOG(ERROR) << "Failed to bind UDP socket: " << result;
+  }
+}
+
+talk_base::SocketAddress UdpPacketSocket::GetLocalAddress() const {
+  return local_address_;

[Wez, 2012/04/25 01:05:33]

nit: Check state_?

[Sergey Ulanov, 2012/04/25 01:21:57]

Done.

+}
+
+talk_base::SocketAddress UdpPacketSocket::GetRemoteAddress() const {
+  // UDP sockets are not connected - this method should never be called.
+  NOTREACHED();
+  return talk_base::SocketAddress();
+}
+
+int UdpPacketSocket::Send(const void* data, size_t data_size) {
+  // UDP sockets are not connected - this method should never be called.
+  NOTREACHED();
+  return EWOULDBLOCK;
+}
+
+int UdpPacketSocket::SendTo(const void* data,
+                            size_t data_size,
+                            const talk_base::SocketAddress& address) {
+  if (error_ != 0) {

[Wez, 2012/04/25 01:05:33]

Check the state_ here?

[Sergey Ulanov, 2012/04/25 01:21:57]

Done.

+    return error_;
+  }
+
+  PP_NetAddress_Private pp_address;
+  if (!SocketAddressToPpAddress(address, &pp_address)) {
+    return EINVAL;
+  }
+
+  if (send_queue_size_ >= kMaxSendBufferSize) {
+    return EWOULDBLOCK;
+  }
+
+  send_queue_.push_back(PendingPacket(data, data_size, pp_address));
+  send_queue_size_ += data_size;
+  DoSend();
+  return data_size;
+}
+
+int UdpPacketSocket::Close() {
+  state_ = STATE_CLOSED;
+  socket_.Close();
+  return 0;
+}
+
+talk_base::AsyncPacketSocket::State UdpPacketSocket::GetState() const {
+  return state_;
+}
+
+int UdpPacketSocket::GetOption(talk_base::Socket::Option opt, int* value) {
+  // Options are not supported for Pepper UDP sockets.
+  return -1;
+}
+
+int UdpPacketSocket::SetOption(talk_base::Socket::Option opt, int value) {
+  // Options are not supported for Pepper UDP sockets.
+  return -1;
+}
+
+int UdpPacketSocket::GetError() const {
+  return error_;
+}
+
+void UdpPacketSocket::SetError(int error) {
+  error_ = error;
+}
+
+void UdpPacketSocket::DoSend() {
+  if (send_pending_ || send_queue_.empty())
+    return;
+
+  int result = socket_.SendTo(
+      send_queue_.front().data->data(), send_queue_.front().data->size(),
+      &send_queue_.front().address,
+      PpCompletionCallback(base::Bind(&UdpPacketSocket::OnSendCompleted,
+                                      base::Unretained(this))));
+  DCHECK_EQ(result, PP_OK_COMPLETIONPENDING);
+  send_pending_ = true;
+}
+
+void UdpPacketSocket::OnSendCompleted(int result) {
+  send_pending_ = false;
+
+  if (result < 0) {
+    if (result != PP_ERROR_ABORTED) {
+      LOG(ERROR) << "Send failed on a UDP socket: " << result;
+    }
+    error_ = EINVAL;
+    return;
+  }
+
+  send_queue_size_ -= send_queue_.front().data->size();
+  send_queue_.pop_front();
+  DoSend();
+}
+
+void UdpPacketSocket::DoRead() {
+  receive_buffer_.resize(kReceiveBufferSize);
+  int result = socket_.RecvFrom(
+      &receive_buffer_[0], receive_buffer_.size(),
+      PpCompletionCallback(base::Bind(&UdpPacketSocket::OnReadCompleted,
+                                      base::Unretained(this))));
+  DCHECK_EQ(result, PP_OK_COMPLETIONPENDING);
+}
+
+void UdpPacketSocket::OnReadCompleted(int result) {
+  HandleReadResult(result);
+  if (result > 0) {
+    DoRead();
+  }
+}
+
+void UdpPacketSocket::HandleReadResult(int result) {
+  if (result > 0) {
+    PP_NetAddress_Private pp_address;
+    if (!socket_.GetRecvFromAddress(&pp_address)) {
+      LOG(ERROR) << "GetRecvFromAddress() failed after successfull RecvFrom().";
+      return;
+    }
+    talk_base::SocketAddress address;
+    if (!PpAddressToSocketAddress(pp_address, &address)) {
+      LOG(ERROR) << "Failed to covert address received from RecvFrom().";
+      return;
+    }
+    SignalReadPacket(this, &receive_buffer_[0], result, address);
+  } else if (result != PP_ERROR_ABORTED) {
+    LOG(ERROR) << "Received error when reading from UDP socket: " << result;
+  }
+}
+
+}  // namespace
+
+PepperPacketSocketFactory::PepperPacketSocketFactory(
+    const pp::InstanceHandle& instance)
+    : pp_instance_(instance) {
+}
+
+PepperPacketSocketFactory::~PepperPacketSocketFactory() {
+}
+
+talk_base::AsyncPacketSocket* PepperPacketSocketFactory::CreateUdpSocket(
+      const talk_base::SocketAddress& local_address,
+      int min_port,
+      int max_port) {
+  scoped_ptr<UdpPacketSocket> result(new UdpPacketSocket(pp_instance_));
+  if (!result->Init(local_address, min_port, max_port))
+    return NULL;
+  return result.release();
+}
+
+talk_base::AsyncPacketSocket* PepperPacketSocketFactory::CreateServerTcpSocket(
+    const talk_base::SocketAddress& local_address,
+    int min_port,
+    int max_port,
+    bool ssl) {
+  // Don't use TCP sockets for remoting connections.

[Wez, 2012/04/25 01:05:33]

nit: "We don't use..."

[Sergey Ulanov, 2012/04/25 01:21:57]

Done.

+  NOTREACHED();
+  return NULL;
+}
+
+talk_base::AsyncPacketSocket* PepperPacketSocketFactory::CreateClientTcpSocket(
+      const talk_base::SocketAddress& local_address,
+      const talk_base::SocketAddress& remote_address,
+      const talk_base::ProxyInfo& proxy_info,
+      const std::string& user_agent,
+      bool ssl) {
+  // Don't use TCP sockets for remoting connections.

[Wez, 2012/04/25 01:05:33]

nit: Here too.

[Sergey Ulanov, 2012/04/25 01:21:57]

Done.

+  NOTREACHED();
+  return NULL;
+}
+
+}  // namespace remoting