Pull shell window stuff out of ExtensionHost and put in ShellWindow

chrome/browser/extensions/platform_app_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
-#include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
+#include "chrome/browser/extensions/platform_app_registry.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/tab_contents/render_view_context_menu.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/extensions/shell_window.h"
 #include "chrome/common/chrome_switches.h"
-#include "chrome/common/chrome_view_type.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/context_menu_params.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/models/menu_model.h"
 
 using content::WebContents;
 
 namespace {
@@ skipping 19 matching lines @@
 class PlatformAppBrowserTest : public ExtensionApiTest {
  public:
   virtual void SetUpCommandLine(CommandLine* command_line) {
     ExtensionBrowserTest::SetUpCommandLine(command_line);
     command_line->AppendSwitch(switches::kEnablePlatformApps);
     command_line->AppendSwitch(switches::kEnableExperimentalExtensionApis);
   }
 
  protected:
   void LoadAndLaunchPlatformApp(const char* name) {
-    size_t platform_app_count = GetPlatformAppCount();
     ui_test_utils::WindowedNotificationObserver app_loaded_observer(
         content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,
         content::NotificationService::AllSources());
 
     EXPECT_TRUE(LoadExtension(test_data_dir_.AppendASCII("platform_apps").
         AppendASCII(name)));
 
     ExtensionService* service = browser()->profile()->GetExtensionService();
     const Extension* extension = service->GetExtensionById(
         last_loaded_extension_id_, false);
     EXPECT_TRUE(extension);
 
     Browser::OpenApplication(
         browser()->profile(),
         extension,
         extension_misc::LAUNCH_NONE,
         GURL(),
         NEW_WINDOW);
 
     app_loaded_observer.Wait();
-
-    // Now we have a new platform app running.
-    EXPECT_EQ(platform_app_count + 1, GetPlatformAppCount());

[benwells, 2012/04/26 08:36:33]

This check is no longer valid and I think was adding limited value.

   }
 
-  // Gets the number of platform apps extension hosts that are running.
-  size_t GetPlatformAppCount() {
-    int count = 0;
-    ExtensionProcessManager* process_manager =
-        browser()->profile()->GetExtensionProcessManager();
-    ExtensionProcessManager::const_iterator iter;
-    ExtensionProcessManager::ExtensionHostSet platform_app_hosts =
-        process_manager->platform_app_hosts();
-    for (iter = platform_app_hosts.begin(); iter != platform_app_hosts.end();
-         ++iter) {
-      if ((*iter)->extension())
-        count++;
-    }
-
-    return count;
-  }
-
-  // Gets the WebContents associated with the ExtensionHost of the first
-  // platform app shell window that is found (most tests only deal with one
-  // platform app window, so this is good enough).
-  WebContents* GetFirstPlatformAppShellWindowWebContents() {
-    ExtensionProcessManager* process_manager =
-        browser()->profile()->GetExtensionProcessManager();
-    ExtensionProcessManager::const_iterator iter;
-    ExtensionProcessManager::ExtensionHostSet platform_app_hosts =
-        process_manager->platform_app_hosts();
-    for (iter = platform_app_hosts.begin(); iter != platform_app_hosts.end();
-         ++iter) {
-      return (*iter)->host_contents();
+  // Gets the WebContents associated with the first shell window that is found
+  // (most tests only deal with one platform app window, so this is good
+  // enough).
+  WebContents* GetFirstShellWindowWebContents() {
+    PlatformAppRegistry* app_registry =
+        PlatformAppRegistry::Get(browser()->profile());
+    PlatformAppRegistry::const_iterator iter;
+    PlatformAppRegistry::ShellWindowSet shell_windows =
+        app_registry->shell_windows();
+    for (iter = shell_windows.begin(); iter != shell_windows.end(); ++iter) {
+      return (*iter)->web_contents();
     }
 
     return NULL;
   }
 };
 
 // Tests that platform apps received the "launch" event when launched.
 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, OnLaunchedEvent) {
   ASSERT_TRUE(RunPlatformAppTest("platform_apps/launch")) << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, EmptyContextMenu) {
   ExtensionTestMessageListener launched_listener("Launched", false);
   LoadAndLaunchPlatformApp("empty_context_menu");
 
   ASSERT_TRUE(launched_listener.WaitUntilSatisfied());
 
   // The empty app doesn't add any context menu items, so its menu should
   // only include the developer tools.
-  WebContents* web_contents = GetFirstPlatformAppShellWindowWebContents();
+  WebContents* web_contents = GetFirstShellWindowWebContents();
   ASSERT_TRUE(web_contents);
   WebKit::WebContextMenuData data;
   content::ContextMenuParams params(data);
   PlatformAppContextMenu* menu = new PlatformAppContextMenu(web_contents,
       params);
   menu->Init();
+  // TODO(benwells): Remove the constant below. Instead of checking the
+  // number of menu items check certain item's absense and presence.
   // 3 including separator
   ASSERT_EQ(3, menu->menu_model().GetItemCount());
 }
 
 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, AppWithContextMenu) {
   ExtensionTestMessageListener launched_listener("Launched", false);
   LoadAndLaunchPlatformApp("context_menu");
 
   // Wait for the extension to tell us it's initialized its context menus and
   // launched a window.
   ASSERT_TRUE(launched_listener.WaitUntilSatisfied());
 
   // The context_menu app has one context menu item. This, along with a
   // separator and the developer tools, is all that should be in the menu.
-  WebContents* web_contents = GetFirstPlatformAppShellWindowWebContents();
+  WebContents* web_contents = GetFirstShellWindowWebContents();
   ASSERT_TRUE(web_contents);
   WebKit::WebContextMenuData data;
   content::ContextMenuParams params(data);
   PlatformAppContextMenu* menu = new PlatformAppContextMenu(web_contents,
       params);
   menu->Init();
+  // TODO(benwells): Remove the constant below. Instead of checking the
+  // number of menu items check certain item's absense and presence.
   ASSERT_EQ(4, menu->menu_model().GetItemCount());
 }
 
 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, DisallowNavigation) {
   ASSERT_TRUE(StartTestServer());
   ASSERT_TRUE(RunPlatformAppTest("platform_apps/navigation")) << message_;
 }
 
 // Tests that localStorage and WebSQL are disabled for platform apps.
 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, DisallowStorage) {
   ASSERT_TRUE(RunPlatformAppTest("platform_apps/storage")) << message_;
 }
 
 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, Restrictions) {
   ASSERT_TRUE(RunPlatformAppTest("platform_apps/restrictions")) << message_;
 }
 
 // Tests that platform apps can use the chrome.windows.* API.
 IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, WindowsApi) {
   ASSERT_TRUE(RunPlatformAppTest("platform_apps/windows_api")) << message_;
 }