[tools] : is a reserved character and shouldn't be used in a query parameter,

[tools] : is a reserved character and shouldn't be used in a query parameter,
but mainly I can't click links spit out by bisect-builds.py in gnome-terminal.
http://www.ietf.org/rfc/rfc2396.txt (sec 3.4)

R=estade@chromium.org
BUG=None
TEST=%3A instead of : and dbeam is happy when he clicks links.
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132750

[Evan Stade, 2012-04-18 04:19:53]

lgtm

-- Evan Stade


On Tue, Apr 17, 2012 at 9:18 PM, <dbeam@chromium.org> wrote:

> Reviewers: Evan Stade,
>
> Description:
> [tools] : is a reserved character and shouldn't be used in a query
> parameter,
> but mainly I can't click links spit out by bisect-builds.py in
> gnome-terminal.
> http://www.ietf.org/rfc/**rfc2396.txt<http://www.ietf.org/rfc/rfc2396.txt>(sec
3.4)
>
> R=estade@chromium.org
> BUG=None
> TEST=%3A instead of : and dbeam is happy when he clicks links.
>
> Please review this at
https://chromiumcodereview.**appspot.com/10119002/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M tools/bisect-builds.py
>
>
> Index: tools/bisect-builds.py
> diff --git a/tools/bisect-builds.py b/tools/bisect-builds.py
> index ef14641e7a8b00482558189824de8e**26f1b4f709..**
> 52b6f2aa139715bc8676ebfd402525**d87e264903 100755
> --- a/tools/bisect-builds.py
> +++ b/tools/bisect-builds.py
> @@ -20,7 +20,7 @@ BUILD_VIEWVC_URL = 'http://src.chromium.org/**
> viewvc/chrome?view=rev&**revision=%d'
>
>  # Changelogs URL.
>  CHANGELOG_URL =
'http://build.chromium.org/f/**chromium/<http://build.chromium.org/f/chromium/>'
> \
> -                'perf/dashboard/ui/changelog.**
> html?url=/trunk/src&range=%d:%**d'
> +                'perf/dashboard/ui/changelog.**
> html?url=/trunk/src&range=%d%%**3A%d'
>
>  # DEPS file URL.
>  DEPS_FILE= 'http://src.chromium.org/**viewvc/chrome/trunk/src/DEPS?**
> revision=%d'
>
>
>

[commit-bot: I haz the power, 2012-04-18 04:31:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/10119002/1

[commit-bot: I haz the power, 2012-04-18 05:55:14]

Change committed as 132750