Implementation for switching between recently used tabs using ctrl tilde or quoteleft.

chrome/browser/ui/gtk/browser_window_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/browser_window_gtk.h"
 
 #include <dlfcn.h>
 #include <gdk/gdkkeysyms.h>
 
 #include <algorithm>
@@ skipping 56 matching lines @@
 #include "chrome/browser/ui/gtk/reload_button_gtk.h"
 #include "chrome/browser/ui/gtk/status_bubble_gtk.h"
 #include "chrome/browser/ui/gtk/tab_contents_container_gtk.h"
 #include "chrome/browser/ui/gtk/tabs/tab_strip_gtk.h"
 #include "chrome/browser/ui/gtk/task_manager_gtk.h"
 #include "chrome/browser/ui/gtk/update_recommended_dialog.h"
 #include "chrome/browser/ui/omnibox/location_bar.h"
 #include "chrome/browser/ui/omnibox/omnibox_view.h"
 #include "chrome/browser/ui/page_info_bubble.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
+#include "chrome/browser/ui/tabs/tab_mru_list_manager.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/webui/task_manager/task_manager_dialog.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/browser/website_settings.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/download_manager.h"
 #include "content/public/browser/native_web_keyboard_event.h"
 #include "content/public/browser/notification_service.h"
@@ skipping 1702 matching lines @@
   g_signal_connect(window_, "delete-event",
                    G_CALLBACK(OnMainWindowDeleteEventThunk), this);
   g_signal_connect(window_, "destroy",
                    G_CALLBACK(OnMainWindowDestroyThunk), this);
   g_signal_connect(window_, "configure-event",
                    G_CALLBACK(OnConfigureThunk), this);
   g_signal_connect(window_, "window-state-event",
                    G_CALLBACK(OnWindowStateThunk), this);
   g_signal_connect(window_, "key-press-event",
                    G_CALLBACK(OnKeyPressThunk), this);
+  g_signal_connect(window_, "key-release-event",
+                   G_CALLBACK(OnKeyReleaseThunk), this);
   g_signal_connect(window_, "motion-notify-event",
                    G_CALLBACK(OnMouseMoveEventThunk), this);
   g_signal_connect(window_, "button-press-event",
                    G_CALLBACK(OnButtonPressEventThunk), this);
   g_signal_connect(window_, "focus-in-event",
                    G_CALLBACK(OnFocusInThunk), this);
   g_signal_connect(window_, "focus-out-event",
                    G_CALLBACK(OnFocusOutThunk), this);
 }
 
@@ skipping 404 matching lines @@
 // override their accelerators, except if there is a priority keybinding
 // handler registered (it should take precedence).
 gboolean BrowserWindowGtk::OnKeyPress(GtkWidget* widget, GdkEventKey* event) {
   if (extension_keybinding_registry_->HasPriorityHandler(event))
     return FALSE;
 
   // If a widget besides the native view is focused, we have to try to handle
   // the custom accelerators before letting it handle them.
   WebContents* current_web_contents =
       browser()->GetSelectedWebContents();
+
+  guint modifier = event->state & gtk_accelerator_get_default_mod_mask();
+  bool is_tab_mru_switch = CommandLine::ForCurrentProcess()->HasSwitch(
+    switches::kEnableTabMRUSwitch);

[sky, 2012/06/15 19:47:39]

spacing is off. Rather than checking switch value, check for non-null
MRUTabController.

[NaveenBobbili (Motorola), 2012/06/25 09:44:23]

Done.

+  if (GDK_CONTROL_MASK == modifier && is_tab_mru_switch) {
+    if ((event->keyval == GDK_KEY_asciitilde) ||
+        (event->keyval == GDK_KEY_quoteleft)) {
+      browser()->tab_mru_list_manager()->CommitActiveTabChanges();
+    }
+    else
+      browser()->tab_mru_list_manager()->PauseStackUpdates();
+  }
+
   // The current tab might not have a render view if it crashed.
   if (!current_web_contents || !current_web_contents->GetContentNativeView() ||
       !gtk_widget_is_focus(current_web_contents->GetContentNativeView())) {
     int command_id = GetCustomCommandId(event);
     if (command_id == -1)
       command_id = GetPreHandleCommandId(event);
 
     if (command_id != -1 && browser_->ExecuteCommandIfEnabled(command_id))
       return TRUE;
 
     // Propagate the key event to child widget first, so we don't override their
     // accelerators.
     if (!gtk_window_propagate_key_event(GTK_WINDOW(widget), event)) {
       if (!gtk_window_activate_key(GTK_WINDOW(widget), event)) {
         gtk_bindings_activate_event(GTK_OBJECT(widget), event);
       }
     }
   } else {
     bool rv = gtk_window_propagate_key_event(GTK_WINDOW(widget), event);
     DCHECK(rv);
   }
 
   // Prevents the default handler from handling this event.
   return TRUE;
 }
 
+gboolean BrowserWindowGtk::OnKeyRelease(GtkWidget* widget, GdkEventKey* event) {
+  bool is_tab_mru_switch = CommandLine::ForCurrentProcess()->HasSwitch(
+    switches::kEnableTabMRUSwitch);

[sky, 2012/06/15 19:47:39]

spacing is off.

[NaveenBobbili (Motorola), 2012/06/25 09:44:23]

Done.

+  if (is_tab_mru_switch &&
+      (event->keyval == GDK_KEY_Control_L ||
+       event->keyval == GDK_KEY_Control_R)) {
+    browser()->tab_mru_list_manager()->CommitActiveTabChanges();
+  }
+
+  return FALSE;
+}
+
 gboolean BrowserWindowGtk::OnMouseMoveEvent(GtkWidget* widget,
                                             GdkEventMotion* event) {
   // This method is used to update the mouse cursor when over the edge of the
   // custom frame.  If the custom frame is off or we're over some other widget,
   // do nothing.
   if (!UseCustomFrame() || event->window != gtk_widget_get_window(widget)) {
     // Reset the cursor.
     if (frame_cursor_) {
       frame_cursor_ = NULL;
       gdk_window_set_cursor(gtk_widget_get_window(GTK_WIDGET(window_)), NULL);
@@ skipping 342 matching lines @@
           wm_type == ui::WM_OPENBOX ||
           wm_type == ui::WM_XFWM4);
 }
 
 // static
 BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser) {
   BrowserWindowGtk* browser_window_gtk = new BrowserWindowGtk(browser);
   browser_window_gtk->Init();
   return browser_window_gtk;
 }