Implementation for switching between recently used tabs using ctrl tilde or quoteleft.

chrome/browser/ui/browser.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #endif  // OS_WIN
@@ skipping 112 matching lines @@
 #include "chrome/browser/ui/panels/panel.h"
 #include "chrome/browser/ui/panels/panel_manager.h"
 #include "chrome/browser/ui/search_engines/search_engine_tab_helper.h"
 #include "chrome/browser/ui/status_bubble.h"
 #include "chrome/browser/ui/sync/browser_synced_window_delegate.h"
 #include "chrome/browser/ui/tab_contents/core_tab_helper.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/browser/ui/tabs/dock_info.h"
 #include "chrome/browser/ui/tabs/tab_finder.h"
 #include "chrome/browser/ui/tabs/tab_menu_model.h"
+#include "chrome/browser/ui/tabs/tab_mru_list_manager.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/web_applications/web_app_ui.h"
 #include "chrome/browser/ui/webui/feedback_ui.h"
 #include "chrome/browser/ui/webui/ntp/app_launcher_handler.h"
 #include "chrome/browser/ui/webui/ntp/new_tab_page_handler.h"
 #include "chrome/browser/ui/webui/options2/content_settings_handler2.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
 #include "chrome/browser/ui/window_sizer.h"
 #include "chrome/browser/upgrade_detector.h"
@@ skipping 197 matching lines @@
 
 ///////////////////////////////////////////////////////////////////////////////
 // Browser, Constructors, Creation, Showing:
 
 Browser::Browser(Type type, Profile* profile)
     : type_(type),
       profile_(profile),
       window_(NULL),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           tab_strip_model_(new TabStripModel(this, profile))),
+      ALLOW_THIS_IN_INITIALIZER_LIST(

[sky, 2012/05/29 19:48:27]

No need for ALLOW_THIS_IN_INITIALIAZER_LIST here.

As indicated in last review, this should be off by default and turned on via
about:flags.

[NaveenBobbili (Motorola), 2012/06/05 05:34:16]

Done.

+          tab_mru_list_manager_(new TabMRUListManager())),
       command_updater_(this),
       app_type_(APP_TYPE_HOST),
       chrome_updater_factory_(this),
       is_attempting_to_close_browser_(false),
       cancel_download_confirmation_state_(NOT_PROMPTED),
       show_state_(ui::SHOW_STATE_DEFAULT),
       is_session_restore_(false),
       weak_factory_(this),
       block_command_execution_(false),
       last_blocked_command_id_(-1),
       last_blocked_command_disposition_(CURRENT_TAB),
       pending_web_app_action_(NONE),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           content_setting_bubble_model_delegate_(
               new BrowserContentSettingBubbleModelDelegate(this))),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           toolbar_model_delegate_(
               new BrowserToolbarModelDelegate(this))),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           tab_restore_service_delegate_(
               new BrowserTabRestoreServiceDelegate(this))),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           synced_window_delegate_(
               new BrowserSyncedWindowDelegate(this))),
       bookmark_bar_state_(BookmarkBar::HIDDEN),
       window_has_shown_(false) {
   tab_strip_model_->AddObserver(this);
+  tab_strip_model_->AddObserver(tab_mru_list_manager_.get());

[sky, 2012/05/29 19:48:28]

TabMRUListManager should take care of adding/removing itself from the model.

[NaveenBobbili (Motorola), 2012/06/05 05:34:16]

Done.

 
   toolbar_model_.reset(new ToolbarModel(toolbar_model_delegate_.get()));
 
   registrar_.Add(this, content::NOTIFICATION_SSL_VISIBLE_STATE_CHANGED,
                  content::NotificationService::AllSources());
   registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED,
                  content::Source<Profile>(profile_->GetOriginalProfile()));
   registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED,
                  content::Source<Profile>(profile_->GetOriginalProfile()));
   registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNINSTALLED,
@@ skipping 59 matching lines @@
 Browser::~Browser() {
   ProfileSyncService* service =
       ProfileSyncServiceFactory::GetInstance()->GetForProfile(profile_);
   if (service)
     service->RemoveObserver(this);
 
   // The tab strip should not have any tabs at this point.
   if (!browser_shutdown::ShuttingDownWithoutClosingBrowsers())
     DCHECK(tab_strip_model_->empty());
   tab_strip_model_->RemoveObserver(this);
+  tab_strip_model_->RemoveObserver(tab_mru_list_manager_.get());
 
   BrowserList::RemoveBrowser(this);
 
   SessionService* session_service =
       SessionServiceFactory::GetForProfile(profile_);
   if (session_service)
     session_service->WindowClosed(session_id_);
 
   TabRestoreService* tab_restore_service =
       TabRestoreServiceFactory::GetForProfile(profile());
@@ skipping 944 matching lines @@
 }
 
 void Browser::CloseTab() {
   content::RecordAction(UserMetricsAction("CloseTab_Accelerator"));
   if (CanCloseTab())
     tab_strip_model_->CloseSelectedTabs();
 }
 
 void Browser::SelectNextTab() {
   content::RecordAction(UserMetricsAction("SelectNextTab"));
-  tab_strip_model_->SelectNextTab();
+  TabContentsWrapper* contents = tab_mru_list_manager_->GetNextMRUTab();

[sky, 2012/05/29 19:48:28]

Don't change selectnexttab.

[NaveenBobbili (Motorola), 2012/06/05 05:34:16]

This creeped in by mistake.Done

+  if (contents)
+    tab_strip_model_->SelectNextTab();
 }
 
 void Browser::SelectPreviousTab() {
   content::RecordAction(UserMetricsAction("SelectPrevTab"));
   tab_strip_model_->SelectPreviousTab();
 }
 
 void Browser::OpenTabpose() {
 #if defined(OS_MACOSX)
   if (!CommandLine::ForCurrentProcess()->HasSwitch(
@@ skipping 23 matching lines @@
     content::RecordAction(UserMetricsAction("SelectNumberedTab"));
     ActivateTabAt(index, true);
   }
 }
 
 void Browser::SelectLastTab() {
   content::RecordAction(UserMetricsAction("SelectLastTab"));
   tab_strip_model_->SelectLastTab();
 }
 
+void Browser::SelectNextMRUTab() {
+  content::RecordAction(UserMetricsAction("SelectNextMRUTab"));
+  TabContentsWrapper* contents = tab_mru_list_manager_->GetNextMRUTab();
+  if (contents)
+    ActivateTabAt(tab_strip_model_->GetIndexOfTabContents(contents), true);
+}
+
 void Browser::DuplicateTab() {
   content::RecordAction(UserMetricsAction("Duplicate"));
   DuplicateContentsAt(active_index());
 }
 
 void Browser::WriteCurrentURLToClipboard() {
   // TODO(ericu): There isn't currently a metric for this.  Should there be?
   // We don't appear to track the action when it comes from the
   // RenderContextViewMenu.
 
@@ skipping 1093 matching lines @@
     case IDC_VIEW_PASSWORDS:        OpenPasswordManager();            break;
     case IDC_CLEAR_BROWSING_DATA:   OpenClearBrowsingDataDialog();    break;
     case IDC_IMPORT_SETTINGS:       OpenImportSettingsDialog();       break;
     case IDC_ABOUT:                 OpenAboutChromeDialog();          break;
     case IDC_UPGRADE_DIALOG:        OpenUpdateChromeDialog();         break;
     case IDC_VIEW_INCOMPATIBILITIES: ShowAboutConflictsTab();         break;
     case IDC_HELP_PAGE:             ShowHelpTab();                    break;
     case IDC_SHOW_SYNC_SETUP:       ShowSyncSetup(SyncPromoUI::SOURCE_MENU);
                                     break;
     case IDC_TOGGLE_SPEECH_INPUT:   ToggleSpeechInput();              break;
+    case IDC_SELECT_NEXT_MRU_TAB:   SelectNextMRUTab();               break;
 
     default:
       LOG(WARNING) << "Received Unimplemented Command: " << id;
       break;
   }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // Browser, TabRestoreServiceObserver:
 
@@ skipping 1485 matching lines @@
   // Navigation commands
   command_updater_.UpdateCommandEnabled(IDC_HOME, normal_window);
 
   // Window management commands
   // TODO(rohitrao): Disable fullscreen on non-Lion?
   command_updater_.UpdateCommandEnabled(IDC_FULLSCREEN,
       !(is_type_panel() && is_app()));
   command_updater_.UpdateCommandEnabled(IDC_SELECT_NEXT_TAB, normal_window);
   command_updater_.UpdateCommandEnabled(IDC_SELECT_PREVIOUS_TAB,
                                         normal_window);
+  command_updater_.UpdateCommandEnabled(IDC_SELECT_NEXT_MRU_TAB,

[sky, 2012/05/29 19:48:28]

Only enable if enabled in about:flags.

[NaveenBobbili (Motorola), 2012/06/05 05:34:16]

Done.

+                                        normal_window);
   command_updater_.UpdateCommandEnabled(IDC_MOVE_TAB_NEXT, normal_window);
   command_updater_.UpdateCommandEnabled(IDC_MOVE_TAB_PREVIOUS, normal_window);
   command_updater_.UpdateCommandEnabled(IDC_SELECT_TAB_0, normal_window);
   command_updater_.UpdateCommandEnabled(IDC_SELECT_TAB_1, normal_window);
   command_updater_.UpdateCommandEnabled(IDC_SELECT_TAB_2, normal_window);
   command_updater_.UpdateCommandEnabled(IDC_SELECT_TAB_3, normal_window);
   command_updater_.UpdateCommandEnabled(IDC_SELECT_TAB_4, normal_window);
   command_updater_.UpdateCommandEnabled(IDC_SELECT_TAB_5, normal_window);
   command_updater_.UpdateCommandEnabled(IDC_SELECT_TAB_6, normal_window);
   command_updater_.UpdateCommandEnabled(IDC_SELECT_TAB_7, normal_window);
@@ skipping 1017 matching lines @@
   if (contents && !allow_js_access) {
     contents->web_contents()->GetController().LoadURL(
         target_url,
         content::Referrer(),
         content::PAGE_TRANSITION_LINK,
         std::string());  // No extra headers.
   }
 
   return contents != NULL;
 }