Remoting daemon process to support unofficial client ID

remoting/host/signaling_connector.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_SIGNALING_CONNECTOR_H
 #define REMOTING_HOST_SIGNALING_CONNECTOR_H
 
 #include "base/basictypes.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/non_thread_safe.h"
@@ skipping 13 matching lines @@
 // backoff. It also monitors network state and reconnects signalling
 // whenever online state changes or IP address changes.
 class SignalingConnector
     : public base::SupportsWeakPtr<SignalingConnector>,
       public base::NonThreadSafe,
       public SignalStrategy::Listener,
       public net::NetworkChangeNotifier::OnlineStateObserver,
       public net::NetworkChangeNotifier::IPAddressObserver,
       public GaiaOAuthClient::Delegate {
  public:
+  // This structure contains information required to perform
+  // authentication to OAuth2.
   struct OAuthCredentials {
     OAuthCredentials(const std::string& login_value,
-                     const std::string& refresh_token_value);
+                     const std::string& refresh_token_value,
+                     const OAuthClientInfo& client_info);
+
+    // ID to identify the user.

[Wez, 2012/04/20 22:29:46]

nit: Suggest "The user's account name (i.e. their email address)"

     std::string login;
+
+    // Secret to authenticate the user.
     std::string refresh_token;

[Wez, 2012/04/20 22:29:46]

nit: Suggest "Token delegating authority to us to act as the user."

+
+    // ID and secret to identify the client.

[Wez, 2012/04/20 22:29:46]

nit: Suggest "Credentials identifying the application to OAuth"

+    OAuthClientInfo client_info;
   };
 
   // OAuth token is updated refreshed when |oauth_credentials| is
   // not NULL.
   SignalingConnector(XmppSignalStrategy* signal_strategy);
   virtual ~SignalingConnector();
 
   void EnableOAuth(scoped_ptr<OAuthCredentials> oauth_credentials,
                    const base::Closure& oauth_failed_callback,
                    URLRequestContextGetter* url_context);
@@ skipping 37 matching lines @@
   base::Time auth_token_expiry_time_;
 
   base::OneShotTimer<SignalingConnector> timer_;
 
   DISALLOW_COPY_AND_ASSIGN(SignalingConnector);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_SIGNALING_CONNECTOR_H