Fix uber tray to accept focus via tab selection

Fix uber tray to accept focus via tab selection


R=sadrul@chromium.org
BUG=119308
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133580

[Jun Mukai, 2012-04-19 04:37:32]

lgtm

[Zachary Kuznia, 2012-04-19 08:26:17]

Hello sky,

Could you do an OWNERS review on this?

Thanks,
-Zach

[sky, 2012-04-19 15:47:49]

Sadrul should review this one.

[sadrul, 2012-04-19 16:12:35]

https://chromiumcodereview.appspot.com/10116018/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/login/webui_login_view.cc (right):

https://chromiumcodereview.appspot.com/10116018/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/login/webui_login_view.cc:326: }
From a quick try, it looks like doing the following here works without changing
anything else:

+  ash::SystemTray* tray = ash::Shell::GetInstance()->tray();
+  tray->SetNextFocusableView(this);
+  ash::Shell::GetInstance()->RotateFocus(reverse ? ash::Shell::BACKWARD :
+                                                   ash::Shell::FORWARD);

Could you test and see if this actually works for all cases? If it does, then
this is probably a simpler fix.

[Zachary Kuznia, 2012-04-23 07:41:48]

https://chromiumcodereview.appspot.com/10116018/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/login/webui_login_view.cc (right):

https://chromiumcodereview.appspot.com/10116018/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/login/webui_login_view.cc:326: }
On 2012/04/19 16:12:35, sadrul wrote:
> From a quick try, it looks like doing the following here works without
changing
> anything else:
> 
> +  ash::SystemTray* tray = ash::Shell::GetInstance()->tray();
> +  tray->SetNextFocusableView(this);
> +  ash::Shell::GetInstance()->RotateFocus(reverse ? ash::Shell::BACKWARD :
> +                                                   ash::Shell::FORWARD);
> 
> Could you test and see if this actually works for all cases? If it does, then
> this is probably a simpler fix.

Done.

[sadrul, 2012-04-23 13:35:05]

On 2012/04/23 07:41:48, Zachary Kuznia wrote:
>
https://chromiumcodereview.appspot.com/10116018/diff/1/chrome/browser/chromeo...
> File chrome/browser/chromeos/login/webui_login_view.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10116018/diff/1/chrome/browser/chromeo...
> chrome/browser/chromeos/login/webui_login_view.cc:326: }
> On 2012/04/19 16:12:35, sadrul wrote:
> > From a quick try, it looks like doing the following here works without
> changing
> > anything else:
> > 
> > +  ash::SystemTray* tray = ash::Shell::GetInstance()->tray();
> > +  tray->SetNextFocusableView(this);
> > +  ash::Shell::GetInstance()->RotateFocus(reverse ? ash::Shell::BACKWARD :
> > +                                                   ash::Shell::FORWARD);
> > 
> > Could you test and see if this actually works for all cases? If it does,
then
> > this is probably a simpler fix.
> 
> Done.

Great! LGTM

[commit-bot: I haz the power, 2012-04-23 23:06:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/10116018/11001

[commit-bot: I haz the power, 2012-04-24 00:43:45]

Change committed as 133580