Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 10115043: Enable the clang plugin by default on linux (when using clang). (Closed)

Created:
8 years, 8 months ago by Nico
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Enable the clang plugin by default on linux (when using clang). BUG=none TEST=GYP_DEFINES=clang=1 gclient runhooks, then build. Plugin prints warnings. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132935

Patch Set 1 #

Patch Set 2 : whoops #

Patch Set 3 : argh gyp #

Patch Set 4 : gyp variable scoping, how does it work #

Patch Set 5 : . #

Patch Set 6 : wtf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M build/common.gypi View 1 2 3 4 5 5 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Nico
You asked for this in the thread "clang + OVERRIDE" on chromium-dev, so you get ...
8 years, 8 months ago (2012-04-18 20:40:08 UTC) #1
willchan no longer on Chromium
lgtm
8 years, 8 months ago (2012-04-18 21:08:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10115043/1
8 years, 8 months ago (2012-04-18 21:14:49 UTC) #3
commit-bot: I haz the power
Try job failure for 10115043-1 on mac_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=18973 Step "update" is always ...
8 years, 8 months ago (2012-04-18 21:17:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10115043/4003
8 years, 8 months ago (2012-04-18 21:28:36 UTC) #5
commit-bot: I haz the power
Try job failure for 10115043-4003 (retry) on android for step "update". It's a second try, ...
8 years, 8 months ago (2012-04-18 21:34:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10115043/2006
8 years, 8 months ago (2012-04-18 23:34:19 UTC) #7
commit-bot: I haz the power
Try job failure for 10115043-2006 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=8042 Step "update" is always ...
8 years, 8 months ago (2012-04-18 23:42:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10115043/2009
8 years, 8 months ago (2012-04-18 23:57:23 UTC) #9
commit-bot: I haz the power
Try job failure for 10115043-2009 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=8046 Step "update" is always ...
8 years, 8 months ago (2012-04-19 00:03:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10115043/10001
8 years, 8 months ago (2012-04-19 00:55:29 UTC) #11
commit-bot: I haz the power
8 years, 8 months ago (2012-04-19 03:40:10 UTC) #12
Change committed as 132935

Powered by Google App Engine
This is Rietveld 408576698