Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: ui/base/resource/resource_bundle_win.cc

Issue 10115029: Set toolbar padding to something appropriate for Metro icons. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Improve comment as requested. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/layout.cc ('k') | ui/ui.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/resource/resource_bundle_win.cc
diff --git a/ui/base/resource/resource_bundle_win.cc b/ui/base/resource/resource_bundle_win.cc
index 2c175343513999138daf08a6f59ed0761e13d6fc..ffb6628125ddbf9afc61acbf386e85186b420cf3 100644
--- a/ui/base/resource/resource_bundle_win.cc
+++ b/ui/base/resource/resource_bundle_win.cc
@@ -5,8 +5,11 @@
#include "ui/base/resource/resource_bundle_win.h"
#include "base/logging.h"
+#include "base/path_service.h"
+#include "ui/base/layout.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/base/resource/resource_data_dll_win.h"
+#include "ui/base/win/dpi.h"
namespace ui {
@@ -41,38 +44,28 @@ void ResourceBundle::LoadCommonResources() {
// As a convenience, add the current resource module as a data packs.
data_packs_.push_back(new ResourceDataDLL(GetCurrentResourceDLL()));
- bool use_hidpi_pak = false;
+ bool use_hidpi = false;
#if defined(ENABLE_HIDPI)
- // If we're running in HiDPI mode then use the 2x resource for DPI greater
- // than 1.5. Otherwise use the 1x resource.
- use_hidpi_pak = ui::GetDPIScale() > 1.5;
+ use_hidpi = ui::GetDPIScale() > 1.5;
#endif
- bool use_metro_pak = false;
-#if defined(ENABLE_METRO)
- use_metro_pak = IsInMetroMode();
-#endif
-
- if (use_metro_pak) {
- AddDataPack(GetResourcesPakFilePath("theme_resources_metro_1x.pak"));
- } else if (use_hidpi_pak) {
- AddDataPack(GetResourcesPakFilePath("theme_resources_2x.pak"));
- } else {
- AddDataPack(GetResourcesPakFilePath("theme_resources_standard.pak"));
- }
-
- if (use_hidpi_pak) {
- AddDataPack(GetResourcesPakFilePath("ui_resources_2x.pak"));
- } else {
- AddDataPack(GetResourcesPakFilePath("ui_resources_standard.pak"));
+ switch (ui::GetDisplayLayout()) {
+ case ui::LAYOUT_METRO:
+ AddDataPack(GetResourcesPakFilePath("theme_resources_metro_1x.pak"));
+ AddDataPack(GetResourcesPakFilePath("ui_resources_standard.pak"));
+ break;
+ default:
+ if (use_hidpi) {
+ AddDataPack(GetResourcesPakFilePath("theme_resources_2x.pak"));
+ AddDataPack(GetResourcesPakFilePath("ui_resources_2x.pak"));
+ } else {
+ AddDataPack(GetResourcesPakFilePath("theme_resources_standard.pak"));
+ AddDataPack(GetResourcesPakFilePath("ui_resources_standard.pak"));
+ }
+ break;
}
}
-void ResourceBundle::LoadTestResources(const FilePath& path) {
- // On Windows, the test resources are normally compiled into the binary
- // itself.
-}
-
gfx::Image& ResourceBundle::GetNativeImageNamed(int resource_id, ImageRTL rtl) {
// Flipped image is not used on Windows.
DCHECK_EQ(rtl, RTL_DISABLED);
« no previous file with comments | « ui/base/layout.cc ('k') | ui/ui.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698