Address the remaining review comments on http://chromiumcodereview.appspot.com/9431029.

lib/compiler/implementation/resolver.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface TreeElements {
   Element operator[](Node node);
   Selector getSelector(Send send);
   Type getType(TypeAnnotation annotation);
 }
 
@@ skipping 1089 matching lines @@
                typeArguments = typeArguments.tail) {
             if (++index > cls.typeParameters.length) {
               report(typeArguments.head, MessageKind.ADDITIONAL_TYPE_ARGUMENT);
             }
             arguments.addLast(resolveTypeAnnotation(typeArguments.head));
           }
           if (index < cls.typeParameters.length) {
             report(node.typeArguments, MessageKind.MISSING_TYPE_ARGUMENT);
           }
         }
-        type = new InterfaceType(cls.name, cls, arguments.toLink());
-      } else if (element.isTypedef()) {
-        // TODO(karlklose): implement typedefs. We return a fake type that the
-        // code generator can use to detect typedefs in is-checks.
-        type = new InterfaceType(element.name, element);
+        if (arguments.length == 0) {
+          type = element.computeType(compiler);

[ahe, 2012/04/19 08:20:06]

I think you have a different design in mind than the one we had in dartc. I
don't know if this is intentional or not, but if it is, I'd like to know what
your plan is.

Let's talk about this f2f.

[karlklose, 2012/04/25 11:45:43]

As discussed, the check must be on the number of type parameters of the class
element instead. Changed.

+        } else {
+          type = new InterfaceType(cls.name, cls, arguments.toLink());
+        }
+      } else if (element.isTypedef() || element.isTypeVariable()) {
+        type = element.computeType(compiler);
       } else {
-        type = element.computeType(compiler);
+        compiler.internalErrorOnElement(element, "unexpected element kind");
       }
     }
     return useType(node, type);
   }
 
   visitModifiers(Modifiers node) {
     // TODO(ngeoffray): Implement this.
     unimplemented(node, 'modifiers');
   }
 
@@ skipping 607 matching lines @@
 
   // TODO(ahe): This is temporary.
   void resolveExpression(Node node) {
     if (node == null) return;
     node.accept(new ResolverVisitor(compiler, enclosingElement));
   }
 
   // TODO(ahe): This is temporary.
   void resolveType(Node node) {
     if (node == null) return;
-    // Find the correct member context to perform the lookup in.
-    Element outer = enclosingElement;
-    Element context = outer;
-    while (outer !== null) {
-      if (outer.isMember()) {
-        context = outer;
-        break;
-      }
-      outer = outer.enclosingElement;
-    }
-    node.accept(new ResolverVisitor(compiler, context));
+    node.accept(new ResolverVisitor(compiler, enclosingElement));
   }
 
   // TODO(ahe): This is temporary.
   ClassElement get currentClass() {
     return enclosingElement.isMember()
       ? enclosingElement.enclosingElement : null;
   }
 }
 
 class ConstructorResolver extends CommonResolverVisitor<Element> {
@@ skipping 148 matching lines @@
 
   TopScope(LibraryElement library) : super(null, library);
   Element lookup(SourceString name) {
     return library.find(name);
   }
 
   Element add(Element newElement) {
     throw "Cannot add an element in the top scope";
   }
 }