Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 10115024: sensors: Remove prototype implementation (Closed)

Created:
8 years, 8 months ago by cwolfe
Modified:
8 years, 8 months ago
Reviewers:
Ian Vollick, jam, oshima, sadrul
CC:
chromium-reviews, nkostylev+watch_chromium.org, ben+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

sensors: Remove prototype implementation Have gotten all the benefits out of this prototype. The animation framework is now being more completely tested from Aura, so no longer depends on this code. Time to pull out the remaining pieces. BUG=None TEST=Manual Chrome OS build and trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133688

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -363 lines) Patch
M chrome/browser/browser_about_handler.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M chrome/browser/chrome_browser_main_extra_parts_ash.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/ui/views/ash/screen_orientation_listener.h View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/ui/views/ash/screen_orientation_listener.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D content/browser/sensors/sensors_provider_impl.h View 1 chunk +0 lines, -41 lines 0 comments Download
D content/browser/sensors/sensors_provider_impl.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -5 lines 0 comments Download
D content/public/browser/sensors.h View 1 chunk +0 lines, -31 lines 0 comments Download
D content/public/browser/sensors_listener.h View 1 chunk +0 lines, -32 lines 0 comments Download
D content/public/browser/sensors_provider.h View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
cwolfe
I ran a `grep -i sensors` over src, so hopefully found where all the pieces ...
8 years, 8 months ago (2012-04-18 20:19:30 UTC) #1
Ian Vollick
On 2012/04/18 20:19:30, cwolfe wrote: > I ran a `grep -i sensors` over src, so ...
8 years, 8 months ago (2012-04-18 20:34:56 UTC) #2
jam
lgtm
8 years, 8 months ago (2012-04-19 01:01:28 UTC) #3
cwolfe
+oshima to make the call on whether we want to keep this screen orientation code ...
8 years, 8 months ago (2012-04-23 14:57:09 UTC) #4
oshima
lgtm ctrl-home on debug build still works right? We may need screen rotation for rotated ...
8 years, 8 months ago (2012-04-23 23:35:10 UTC) #5
cwolfe
Traced the ctrl-home path: it's completely independent, so should not be affected by this change. ...
8 years, 8 months ago (2012-04-24 14:16:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cwolfe@chromium.org/10115024/1
8 years, 8 months ago (2012-04-24 14:17:04 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-24 15:42:02 UTC) #8
Change committed as 133688

Powered by Google App Engine
This is Rietveld 408576698