Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 10115017: Cleanup: IWYU for base/file_util_proxy.h. (Closed)

Created:
8 years, 8 months ago by Lei Zhang
Modified:
8 years, 8 months ago
CC:
chromium-reviews, erikwright (departed), jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Cleanup: IWYU for base/file_util_proxy.h. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133520

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M base/file_util_proxy.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M base/file_util_proxy.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/redirect_to_file_resource_handler.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/blob/local_file_reader.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/quota_file_io.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/simple_file_writer.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
I think a review from you satisfies all OWNERS requirements.
8 years, 8 months ago (2012-04-18 03:17:50 UTC) #1
darin (slow to review)
LGTM
8 years, 8 months ago (2012-04-23 16:56:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10115017/9001
8 years, 8 months ago (2012-04-23 19:13:53 UTC) #3
commit-bot: I haz the power
Can't apply patch for file base/file_util_proxy.cc. While running patch -p0 --forward --force; patching file base/file_util_proxy.cc ...
8 years, 8 months ago (2012-04-23 19:13:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/10115017/17001
8 years, 8 months ago (2012-04-23 19:49:25 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 21:23:10 UTC) #6
Change committed as 133520

Powered by Google App Engine
This is Rietveld 408576698