Static members are not visible in subclasses

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/compiler_stats.h"
@@ skipping 6883 matching lines @@
   Isolate* isolate = Isolate::Current();
   // First try to find the identifier in the nested local scopes.
   LocalVariable* local = LookupLocalScope(ident);
   if (local != NULL) {
     if (node != NULL) {
       *node = new LoadLocalNode(ident_pos, *local);
     }
     return true;
   }
 
-  // Try to find the identifier in the class scope.
+  // Try to find the identifier in the class scope of the current class.
   Class& cls = Class::Handle(isolate, current_class().raw());
   Function& func = Function::Handle(isolate, Function::null());
   Field& field = Field::Handle(isolate, Field::null());
-  while (!cls.IsNull()) {
-    // First check if a field exists.
-    field = cls.LookupField(ident);
-    if (!field.IsNull()) {
+
+  // First check if a field exists.
+  field = cls.LookupField(ident);
+  if (!field.IsNull()) {
+    if (node != NULL) {
+      if (!field.is_static()) {
+        CheckInstanceFieldAccess(ident_pos, ident);
+        *node = CallGetter(ident_pos, LoadReceiver(ident_pos), ident);
+      } else {
+        *node = GenerateStaticFieldLookup(field, ident_pos);
+      }
+    }
+    return true;
+  }
+
+  // Check if an instance/static function exists.
+  func = cls.LookupFunction(ident);
+  if (!func.IsNull() &&
+      (func.IsDynamicFunction() || func.IsStaticFunction())) {
+    if (node != NULL) {
+      *node = new PrimaryNode(ident_pos,
+                              Function::ZoneHandle(isolate, func.raw()));
+    }
+    return true;
+  }
+
+  // Now check if a getter/setter method exists for it in which case
+  // it is still a field.
+  func = cls.LookupGetterFunction(ident);
+  if (!func.IsNull()) {
+    if (func.IsDynamicFunction()) {
       if (node != NULL) {
-        if (!field.is_static()) {
-          CheckInstanceFieldAccess(ident_pos, ident);
-          *node = CallGetter(ident_pos, LoadReceiver(ident_pos), ident);
-        } else {
-          *node = GenerateStaticFieldLookup(field, ident_pos);
-        }
+        CheckInstanceFieldAccess(ident_pos, ident);
+        ASSERT(AbstractType::Handle(func.result_type()).IsResolved());
+        *node = CallGetter(ident_pos, LoadReceiver(ident_pos), ident);
+      }
+      return true;
+    } else if (func.IsStaticFunction()) {
+      if (node != NULL) {
+        ASSERT(AbstractType::Handle(func.result_type()).IsResolved());
+        *node = new StaticGetterNode(ident_pos,
+                                     Class::ZoneHandle(isolate, cls.raw()),
+                                     ident);
       }
       return true;
     }
-
-    // Check if an instance/static function exists.
-    func = cls.LookupFunction(ident);
-    if (!func.IsNull() &&
-        (func.IsDynamicFunction() || func.IsStaticFunction())) {
+  }
+  func = cls.LookupSetterFunction(ident);
+  if (!func.IsNull()) {
+    if (func.IsDynamicFunction()) {
       if (node != NULL) {
-        *node = new PrimaryNode(ident_pos,
-                                Function::ZoneHandle(isolate, func.raw()));
+        // We create a getter node even though a getter doesn't exist as
+        // it could be followed by an assignment which will convert it to
+        // a setter node. If there is no assignment we will get an error
+        // when we try to invoke the getter.
+        CheckInstanceFieldAccess(ident_pos, ident);
+        ASSERT(AbstractType::Handle(func.result_type()).IsResolved());
+        *node = CallGetter(ident_pos, LoadReceiver(ident_pos), ident);
+      }
+      return true;
+    } else if (func.IsStaticFunction()) {
+      if (node != NULL) {
+        // We create a getter node even though a getter doesn't exist as
+        // it could be followed by an assignment which will convert it to
+        // a setter node. If there is no assignment we will get an error
+        // when we try to invoke the getter.
+        *node = new StaticGetterNode(ident_pos,
+                                     Class::ZoneHandle(isolate, cls.raw()),
+                                     ident);
       }
       return true;
     }
+  }
 
-    // Now check if a getter/setter method exists for it in which case
-    // it is still a field.
-    func = cls.LookupGetterFunction(ident);
-    if (!func.IsNull()) {
-      if (func.IsDynamicFunction()) {
-        if (node != NULL) {
-          CheckInstanceFieldAccess(ident_pos, ident);
-          ASSERT(AbstractType::Handle(func.result_type()).IsResolved());
-          *node = CallGetter(ident_pos, LoadReceiver(ident_pos), ident);
-        }
-        return true;
-      } else if (func.IsStaticFunction()) {
-        if (node != NULL) {
-          ASSERT(AbstractType::Handle(func.result_type()).IsResolved());
-          *node = new StaticGetterNode(ident_pos,
-                                       Class::ZoneHandle(isolate, cls.raw()),
-                                       ident);
-        }
-        return true;
-      }
-    }
-    func = cls.LookupSetterFunction(ident);
-    if (!func.IsNull()) {
-      if (func.IsDynamicFunction()) {
-        if (node != NULL) {
-          // We create a getter node even though a getter doesn't exist as
-          // it could be followed by an assignment which will convert it to
-          // a setter node. If there is no assignment we will get an error
-          // when we try to invoke the getter.
-          CheckInstanceFieldAccess(ident_pos, ident);
-          ASSERT(AbstractType::Handle(func.result_type()).IsResolved());
-          *node = CallGetter(ident_pos, LoadReceiver(ident_pos), ident);
-        }
-        return true;
-      } else if (func.IsStaticFunction()) {
-        if (node != NULL) {
-          // We create a getter node even though a getter doesn't exist as
-          // it could be followed by an assignment which will convert it to
-          // a setter node. If there is no assignment we will get an error
-          // when we try to invoke the getter.
-          *node = new StaticGetterNode(ident_pos,
-                                       Class::ZoneHandle(isolate, cls.raw()),
-                                       ident);
-        }
-        return true;
-      }
-    }
-
-    cls = cls.SuperClass();
-  }
+  // Nothing found in scope of current class.

[siva, 2012/04/18 00:56:23]

As discussed offline we need to figure if this will cause a performance
regression in the benchmarks and startup times. If it does impact performance
then it might make sense to add a ResolveInSuperClasses which only tries to
resolve instance fields/functions in the superclass.

[hausner, 2012/04/18 16:49:26]

Yes. If necessary, I will do that as a separate change.

On 2012/04/18 00:56:23, asiva wrote:

   if (node != NULL) {
     *node = NULL;
   }
   return false;  // Not an unqualified identifier.
 }
 
 
 // Do a lookup for the identifier in the library scope of the specified
 // library. If resolve_locally is true the lookup does not consider
 // the libraries imported by it for the lookup.
@@ skipping 1394 matching lines @@
 void Parser::SkipQualIdent() {
   ASSERT(IsIdentifier());
   ConsumeToken();
   if (CurrentToken() == Token::kPERIOD) {
     ConsumeToken();  // Consume the kPERIOD token.
     ExpectIdentifier("identifier expected after '.'");
   }
 }
 
 }  // namespace dart