Set Android/V8 memory limits from dalvik.vm.heapsize.

base/sys_info_android.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/sys_info.h"
+
+#include <sys/system_properties.h>
+
+#include "base/logging.h"
+#include "base/string_number_conversions.h"
+
+namespace {
+
+int ParseHeapSize(const std::string& str) {

[darin (slow to review), 2012/05/24 22:27:43]

nit: consider changing the parameter to base::StringPiece.
the code should just all be the same otherwise, and then you won't need the
std::string(heap_size_str) at the call-site.

[ulan, 2012/05/25 14:14:36]

Done.

+  const int64 KB = 1024;
+  const int64 MB = 1024 * KB;
+  const int64 GB = 1024 * MB;
+  CHECK_GT(str.size(), 0u);
+  int64 factor = 1;
+  size_t length = str.size();
+  if (str[length - 1] == 'k') {
+    factor = KB;
+    length--;
+  } else if (str[length - 1] == 'm') {
+    factor = MB;
+    length--;
+  } else if (str[length - 1] == 'g') {
+    factor = GB;
+    length--;
+  } else {
+    CHECK('0' <= str[length - 1] && str[length - 1] <= '9');
+  }
+  int64 result = 0;
+  bool parsed = base::StringToInt64(str.substr(0, length), &result);
+  CHECK(parsed);
+  result = result * factor / MB;
+  // dalvik.vm.heapsize property is writable by user,
+  // truncate it to reasonable value to avoid overflows later.
+  result = std::min<int64>(std::max<int64>(32, result), 1024);
+  return static_cast<int>(result);
+}
+
+int GetDalvikHeapSizeMB() {
+  char heap_size_str[PROP_VALUE_MAX];
+  __system_property_get("dalvik.vm.heapsize", heap_size_str);
+  return ParseHeapSize(std::string(heap_size_str));
+}
+
+}  // anonymous namespace
+
+namespace base {
+
+int SysInfo::DalvikHeapSizeMB() {
+  static int heap_size = GetDalvikHeapSizeMB();
+  return heap_size;
+}
+
+}  // namespace base