Issue 10113001: Move section CSS to uber_shared to share with other uber pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10113001: Move section CSS to uber_shared to share with other uber pages. (Closed)

Created:
8 years, 8 months ago by flackr

Modified:
8 years, 8 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move section CSS to uber_shared to share with other uber pages. The definition for the header on the version page was intended to match the section width defined in options_page.css. Help uses sections for the version information which needs to be restricted to the width of the header to avoid overflow. BUG=122973 TEST=Open help page, expand information and scroll down. Version text is restricted to width of header and doesn't overflow. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132590

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -19 lines)			Patch
	M	chrome/browser/resources/options2/options_page.css	View		1 chunk	+0 lines, -19 lines	0 comments	Download
	M	chrome/browser/resources/uber/uber_shared.css	View		1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/10113001/1

8 years, 8 months ago (2012-04-17 15:32:06 UTC) #3

Change committed as 132590

Expand Messages | Collapse Messages