Issue 10108028: Extract the averaged time values from incomming protobuf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10108028: Extract the averaged time values from incomming protobuf (Closed)

Created:
8 years, 8 months ago by rharrison

Modified:
8 years, 8 months ago

Reviewers:
satorux1, sadrul

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Extract the averaged time values from incomming protobuf This CL adds in extracting the averaged battery time values from the incomming protobuf and storing it in an instance of PowerSupplyStatus. BUG=chromium-os:23647 TEST=Confirmed that build still worked. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133080

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -0 lines)			Patch
M	ash/system/power/power_supply_status.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	ash/system/power/power_supply_status.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chromeos/dbus/power_manager_client.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chromeos/dbus/power_supply_status.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chromeos/dbus/power_supply_status.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

rharrison

On 2012/04/18 19:18:31, satorux1 wrote: > LGTM I am waiting for ChromeOS side of this ...

8 years, 8 months ago (2012-04-18 19:21:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rharrison@chromium.org/10108028/1

8 years, 8 months ago (2012-04-19 18:59:07 UTC) #5

Change committed as 133080

Expand Messages | Collapse Messages