Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 10108016: Refactored MediaStreamImpl to be a RenderViewObserver as the other delegates in RenderViewImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed messed up MockMediaStreamImpl. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 #pragma once 7 #pragma once
8 8
9 #include <deque> 9 #include <deque>
10 #include <map> 10 #include <map>
(...skipping 1204 matching lines...) Expand 10 before | Expand all | Expand 10 after
1215 1215
1216 // The speech dispatcher attached to this view, lazily initialized. 1216 // The speech dispatcher attached to this view, lazily initialized.
1217 InputTagSpeechDispatcher* input_tag_speech_dispatcher_; 1217 InputTagSpeechDispatcher* input_tag_speech_dispatcher_;
1218 1218
1219 // Device orientation dispatcher attached to this view; lazily initialized. 1219 // Device orientation dispatcher attached to this view; lazily initialized.
1220 DeviceOrientationDispatcher* device_orientation_dispatcher_; 1220 DeviceOrientationDispatcher* device_orientation_dispatcher_;
1221 1221
1222 // MediaStream dispatcher attached to this view; lazily initialized. 1222 // MediaStream dispatcher attached to this view; lazily initialized.
1223 MediaStreamDispatcher* media_stream_dispatcher_; 1223 MediaStreamDispatcher* media_stream_dispatcher_;
1224 1224
1225 // MediaStreamImpl attached to this view; lazily initialized. 1225 // MediaStreamImpl attached to this view; lazily initialized.
tommi (sloooow) - chröme 2012/04/20 08:21:35 document who owns and deletes? (also if there are
perkj_chrome 2012/04/23 08:23:33 This is how all other RenderViewObservers are docu
1226 scoped_refptr<MediaStreamImpl> media_stream_impl_; 1226 MediaStreamImpl* media_stream_impl_;
1227 1227
1228 // Dispatches all P2P socket used by the renderer. 1228 // Dispatches all P2P socket used by the renderer.
1229 content::P2PSocketDispatcher* p2p_socket_dispatcher_; 1229 content::P2PSocketDispatcher* p2p_socket_dispatcher_;
1230 1230
1231 DevToolsAgent* devtools_agent_; 1231 DevToolsAgent* devtools_agent_;
1232 1232
1233 RendererAccessibility* renderer_accessibility_; 1233 RendererAccessibility* renderer_accessibility_;
1234 1234
1235 // Java Bridge dispatcher attached to this view; lazily initialized. 1235 // Java Bridge dispatcher attached to this view; lazily initialized.
1236 scoped_ptr<JavaBridgeDispatcher> java_bridge_dispatcher_; 1236 scoped_ptr<JavaBridgeDispatcher> java_bridge_dispatcher_;
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
1331 // bunch of stuff, you should probably create a helper class and put your 1331 // bunch of stuff, you should probably create a helper class and put your
1332 // data and methods on that to avoid bloating RenderView more. You can 1332 // data and methods on that to avoid bloating RenderView more. You can
1333 // use the Observer interface to filter IPC messages and receive frame change 1333 // use the Observer interface to filter IPC messages and receive frame change
1334 // notifications. 1334 // notifications.
1335 // --------------------------------------------------------------------------- 1335 // ---------------------------------------------------------------------------
1336 1336
1337 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1337 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1338 }; 1338 };
1339 1339
1340 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1340 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW
« no previous file with comments | « content/renderer/media/peer_connection_handler_unittest.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698