Issue 10108016: Refactored MediaStreamImpl to be a RenderViewObserver as the other delegates in RenderViewImpl.

Issue 10108016: Refactored MediaStreamImpl to be a RenderViewObserver as the other delegates in RenderViewImpl. (Closed)

Created:
8 years, 8 months ago by perkj_chrome

Modified:
8 years, 8 months ago

Reviewers:
tommi (sloooow) - chröme, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactored MediaStreamImpl to be a RenderViewObserver as the other delegates in RenderViewImpl. Reenabled the MediaStreamImpl unit tests. This supersedes https://chromiumcodereview.appspot.com/9368022/ BUG=112408 TEST=unit test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133417

Patch Set 3 : Fixed messed up MockMediaStreamImpl. #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -72 lines)			Patch
M	content/renderer/media/media_stream_impl.h	View		3 chunks	+10 lines, -4 lines	0 comments	Download
M	content/renderer/media/media_stream_impl.cc	View		3 chunks	+5 lines, -3 lines	0 comments	Download
M	content/renderer/media/media_stream_impl_unittest.cc	View	1	1 chunk	+40 lines, -52 lines	0 comments	Download
M	content/renderer/media/mock_media_stream_impl.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/media/peer_connection_handler_jsep_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/media/peer_connection_handler_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/render_view_impl.h	View		1 chunk	+1 line, -1 line	2 comments	Download
M	content/renderer/render_view_impl.cc	View		7 chunks	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

perkj_chrome

Humm - I was just about to ping you about this one. But it seems ...

8 years, 8 months ago (2012-04-20 08:02:02 UTC) #1

tommi (sloooow) - chröme

lgtm http://codereview.chromium.org/10108016/diff/7001/content/renderer/render_view_impl.h File content/renderer/render_view_impl.h (right): http://codereview.chromium.org/10108016/diff/7001/content/renderer/render_view_impl.h#newcode1225 content/renderer/render_view_impl.h:1225: // MediaStreamImpl attached to this view; lazily initialized. ...

8 years, 8 months ago (2012-04-20 08:21:35 UTC) #2

perkj_chrome

Hi, piman Can you help me review the changes in RenderView? This cl cleanup the ...

8 years, 8 months ago (2012-04-20 09:11:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/10108016/7001

8 years, 8 months ago (2012-04-23 08:22:57 UTC) #5

perkj_chrome

http://codereview.chromium.org/10108016/diff/7001/content/renderer/render_view_impl.h File content/renderer/render_view_impl.h (right): http://codereview.chromium.org/10108016/diff/7001/content/renderer/render_view_impl.h#newcode1225 content/renderer/render_view_impl.h:1225: // MediaStreamImpl attached to this view; lazily initialized. On ...

8 years, 8 months ago (2012-04-23 08:23:32 UTC) #6

Change committed as 133417

Expand Messages | Collapse Messages