Move VideoCapture::VideoCaptureCapability to video_capture_types.h

Move VideoCapture::VideoCaptureCapability to video_capture_types.h
This is a first patch of merge VideoCaptureDevice::Capability with VideoCaptureCapability, just for the convenience of review.

BUG=123738
TEST=media_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132742

[Jeremy Mao, 2012-04-17 07:02:06]

Hi wjia,piman,
Could you please take a look at this when you are free?

Thanks
/Jeremy

[piman, 2012-04-17 15:58:50]

lgtm

[wjia(left Chromium), 2012-04-17 16:48:36]

LGTM. Thanks for doing this!

[wjia(left Chromium), 2012-04-17 16:49:07]

+scherkus@ for media/ owner.

[scherkus (not reviewing), 2012-04-17 17:39:22]

lgtm w/ nits

thanks for fixing TODOs :)

http://codereview.chromium.org/10108009/diff/1/content/renderer/media/video_c...
File content/renderer/media/video_capture_impl_unittest.cc (right):

http://codereview.chromium.org/10108009/diff/1/content/renderer/media/video_c...
content/renderer/media/video_capture_impl_unittest.cc:133:
media::VideoCaptureCapability capability =
nit: this can fit on one line

http://codereview.chromium.org/10108009/diff/1/content/renderer/media/video_c...
content/renderer/media/video_capture_impl_unittest.cc:156:
media::VideoCaptureCapability capability =
nit: this can fit on one line

http://codereview.chromium.org/10108009/diff/1/content/renderer/media/video_c...
content/renderer/media/video_capture_impl_unittest.cc:197:
media::VideoCaptureCapability capability_small =
nit: this can fit on one line

http://codereview.chromium.org/10108009/diff/1/content/renderer/media/video_c...
content/renderer/media/video_capture_impl_unittest.cc:199:
media::VideoCaptureCapability capability_large =
nit: this can fit on one line

http://codereview.chromium.org/10108009/diff/1/content/renderer/media/video_c...
content/renderer/media/video_capture_impl_unittest.cc:234:
media::VideoCaptureCapability capability_small =
ditto for these two

http://codereview.chromium.org/10108009/diff/1/media/video/capture/video_capt...
File media/video/capture/video_capture_types.h (right):

http://codereview.chromium.org/10108009/diff/1/media/video/capture/video_capt...
media/video/capture/video_capture_types.h:26: int width;  // desired width.
nit: captialize first letters on these comments

[Jeremy Mao, 2012-04-18 01:07:20]

On 2012/04/17 17:39:22, scherkus wrote:
> lgtm w/ nits
> 
> thanks for fixing TODOs :)
> 
>
http://codereview.chromium.org/10108009/diff/1/content/renderer/media/video_c...
> File content/renderer/media/video_capture_impl_unittest.cc (right):
> 
>
http://codereview.chromium.org/10108009/diff/1/content/renderer/media/video_c...
> content/renderer/media/video_capture_impl_unittest.cc:133:
> media::VideoCaptureCapability capability =
> nit: this can fit on one line
fixed
> 
>
http://codereview.chromium.org/10108009/diff/1/content/renderer/media/video_c...
> content/renderer/media/video_capture_impl_unittest.cc:156:
> media::VideoCaptureCapability capability =
> nit: this can fit on one line
fixed
> 
>
http://codereview.chromium.org/10108009/diff/1/content/renderer/media/video_c...
> content/renderer/media/video_capture_impl_unittest.cc:197:
> media::VideoCaptureCapability capability_small =
> nit: this can fit on one line
fixed
> 
>
http://codereview.chromium.org/10108009/diff/1/content/renderer/media/video_c...
> content/renderer/media/video_capture_impl_unittest.cc:199:
> media::VideoCaptureCapability capability_large =
> nit: this can fit on one line
fixed
> 
>
http://codereview.chromium.org/10108009/diff/1/content/renderer/media/video_c...
> content/renderer/media/video_capture_impl_unittest.cc:234:
> media::VideoCaptureCapability capability_small =
> ditto for these two
fixed
> 
>
http://codereview.chromium.org/10108009/diff/1/media/video/capture/video_capt...
> File media/video/capture/video_capture_types.h (right):
> 
>
http://codereview.chromium.org/10108009/diff/1/media/video/capture/video_capt...
> media/video/capture/video_capture_types.h:26: int width;  // desired width.
> nit: captialize first letters on these comments
fixed

[commit-bot: I haz the power, 2012-04-18 01:09:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yujie.mao@intel.com/10108009/5001

[commit-bot: I haz the power, 2012-04-18 01:37:00]

Try job failure for 10108009-5001 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-18 02:13:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yujie.mao@intel.com/10108009/5004

[commit-bot: I haz the power, 2012-04-18 04:46:54]

Change committed as 132742